Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200643

Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 2015-08-05 at 18:16 +0800, Jia-Ju Bai wrote:
> When e1000e_setup_rx_resources is failed in e1000_open,
> e1000e_free_tx_resources in "err_setup_rx" segment is executed.
> "writel(0, tx_ring->head)" statement in e1000_clean_tx_ring
> in e1000e_free_tx_resources will cause a null poonter
> dereference(crash),
> because "tx_ring->head" is only assigned in e1000_configure_tx
> in e1000_configure, but it is after e1000e_setup_rx_resources.
> 
> This patch moves head/tail register writing to e1000_configure_tx/rx, 
> which can fix this problem. It is inspired by igb_configure_tx_ring 
> in the igb driver.
> 
> Specially, thank Alexander Duyck for his valuable suggestion.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c |   24
> ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Is your intention that this patch replace the existing patch:
http://patchwork.ozlabs.org/patch/502990/
...which is currently in my queue?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] e1000e: Modify tx/rx configurations to avoid null pointer dereferences in e1000_open Jia-Ju Bai <baijiaju1990@163.com> - 2015-08-05 12:20 +0200
  Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null  pointer dereferences in e1000_open Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-08-05 12:50 +0200
    Re: [PATCH v2] e1000e: Modify tx/rx configurations to avoid null  pointer dereferences in e1000_open Jia-Ju Bai <baijiaju1990@163.com> - 2015-08-05 14:40 +0200
  RE: [Intel-wired-lan] [PATCH v2] e1000e: Modify tx/rx  configurations to avoid null pointer dereferences in e1000_open "Brown, Aaron F" <aaron.f.brown@intel.com> - 2015-08-15 01:30 +0200

csiph-web