Groups > linux.kernel > #1207346

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

From	Tadeusz Struk <tadeusz.struk@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer
Date	2015-08-14 08:20 +0200
Message-ID	<pXgvo-2aV-41@gated-at.bofh.it> (permalink)
References	<pWRQm-8uz-5@gated-at.bofh.it> <pWRQm-8uz-9@gated-at.bofh.it> <pXfzk-QH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/13/2015 10:14 PM, Herbert Xu wrote:
>> diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> > index fe352a6..6ddb13c 100644
>> > --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> > +++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
>> > @@ -144,9 +144,6 @@ static void qat_rsa_cb(struct icp_qat_fw_pke_resp *resp)
>> >  		ptr++;
>> >  	}
>> >  
>> > -	if (areq->dst_len != req->ctx->key_sz)
>> > -		memcpy(areq->dst, ptr, areq->dst_len);
>> > -
> This looks wrong.  It appears to be trying to remove leading
> zeroes so you can't just change the length because then you end
> up removing the trailing digits equal to the number of leading
> zeroes.

What it does is it sets the size of the output number, not the size of the output buffer.
The size of the buffer is set beforehand to the size of the modulo, which is the biggest
possible output.

> 
> The existing code is also wrong as you should be using memmove
> instead of memcpy.

Right, but we don't need that anymore.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-13 06:00 +0200
  Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-13 18:50 +0200
  Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-14 07:20 +0200
    Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 08:20 +0200
      Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-14 08:30 +0200
        Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 16:30 +0200
          Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-17 10:50 +0200
        Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 16:30 +0200
          Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-17 11:00 +0200
            Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-18 03:10 +0200
              Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-18 04:50 +0200

csiph-web