Groups > linux.kernel > #1207336

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer
Date	2015-08-14 07:20 +0200
Message-ID	<pXfzk-QH-1@gated-at.bofh.it> (permalink)
References	<pWRQm-8uz-5@gated-at.bofh.it> <pWRQm-8uz-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 12, 2015 at 08:54:45PM -0700, Tadeusz Struk wrote:
> Don't need to move data inside of the output buffer
> because SW doen't need to do this anymore sice the new MPI
> mpi_read_buf() has been added. Just set the correct output len.
> 
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
>  drivers/crypto/qat/qat_common/qat_asym_algs.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/crypto/qat/qat_common/qat_asym_algs.c b/drivers/crypto/qat/qat_common/qat_asym_algs.c
> index fe352a6..6ddb13c 100644
> --- a/drivers/crypto/qat/qat_common/qat_asym_algs.c
> +++ b/drivers/crypto/qat/qat_common/qat_asym_algs.c
> @@ -144,9 +144,6 @@ static void qat_rsa_cb(struct icp_qat_fw_pke_resp *resp)
>  		ptr++;
>  	}
>  
> -	if (areq->dst_len != req->ctx->key_sz)
> -		memcpy(areq->dst, ptr, areq->dst_len);
> -

This looks wrong.  It appears to be trying to remove leading
zeroes so you can't just change the length because then you end
up removing the trailing digits equal to the number of leading
zeroes.

The existing code is also wrong as you should be using memmove
instead of memcpy.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-13 06:00 +0200
  Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-13 18:50 +0200
  Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-14 07:20 +0200
    Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 08:20 +0200
      Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-14 08:30 +0200
        Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 16:30 +0200
          Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-17 10:50 +0200
        Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-14 16:30 +0200
          Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-17 11:00 +0200
            Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Tadeusz Struk <tadeusz.struk@intel.com> - 2015-08-18 03:10 +0200
              Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer Herbert Xu <herbert@gondor.apana.org.au> - 2015-08-18 04:50 +0200

csiph-web