Groups > linux.kernel > #1208117

Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a tristate option

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a tristate option
Date	2015-08-15 18:10 +0200
Message-ID	<pXMbW-6p2-51@gated-at.bofh.it> (permalink)
References	<pWRQl-8uz-3@gated-at.bofh.it> <pWRQm-8uz-27@gated-at.bofh.it> <pXFDr-5g2-7@gated-at.bofh.it> <pXLzc-5pY-7@gated-at.bofh.it> <pXM2e-5Yk-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 15, 2015 at 8:58 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Sat, Aug 15, 2015 at 08:28:35AM -0700, Dan Williams wrote:
>> I'm not grokking the argument against allowing this functionality to
>> be modular.
>
> You're adding a another layer of platform_devices just to make a tivially
> small piece of code modular so that you can hook into it.  I don't think
> that's a good reason, and neither is the after thought of preventing
> potentially future buggy firmware.

What other layer? /sys/devices/platform/e820_pmem is that exact same
device we had before this patch.  We just have a proper driver for it
now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC PATCH 0/7] 'struct page' driver for persistent memory Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 2/7] x86, mm: introduce struct vmem_altmap Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 5/7] libnvdimm,  e820: make CONFIG_X86_PMEM_LEGACY a tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
    Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200
      Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-15 17:30 +0200
        Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-15 18:00 +0200
          Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-15 18:10 +0200
            Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-17 17:10 +0200
              Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-17 17:50 +0200
  [RFC PATCH 3/7] x86, mm: arch_add_dev_memory() Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 7/7] libnvdimm, pmem: 'struct page' for pmem Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 4/7] mm: register_dev_memmap() Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
    Re: [RFC PATCH 4/7] mm: register_dev_memmap() Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200
  [RFC PATCH 6/7] libnvdimm,  pfn: 'struct page' provider infrastructure Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  Re: [RFC PATCH 0/7] 'struct page' driver for persistent memory Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200

csiph-web