Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208044

Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a tristate option

Show all headers | View raw

On Wed, Aug 12, 2015 at 11:50:29PM -0400, Dan Williams wrote:
> Purely for ease of testing, with this in place we can run the unit test
> alongside any tests that depend on the memmap=ss!nn kernel parameter.
> The unit test mocking implementation requires that libnvdimm be a module
> and not built-in.
> 
> A nice side effect is the implementation is a bit more generic as it no
> longer depends on <asm/e820.h>.

I really don't like this artifical split, and I also don't like how
your weird "unit tests" force even more ugliness on the kernel.  Almost
reminds of the python projects spending more effort on getting their
class mockable than actually producing results..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/7] 'struct page' driver for persistent memory Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 2/7] x86, mm: introduce struct vmem_altmap Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 5/7] libnvdimm,  e820: make CONFIG_X86_PMEM_LEGACY a tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
    Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200
      Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-15 17:30 +0200
        Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-15 18:00 +0200
          Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-15 18:10 +0200
            Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Christoph Hellwig <hch@lst.de> - 2015-08-17 17:10 +0200
              Re: [RFC PATCH 5/7] libnvdimm, e820: make CONFIG_X86_PMEM_LEGACY a  tristate option Dan Williams <dan.j.williams@intel.com> - 2015-08-17 17:50 +0200
  [RFC PATCH 3/7] x86, mm: arch_add_dev_memory() Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 7/7] libnvdimm, pmem: 'struct page' for pmem Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  [RFC PATCH 4/7] mm: register_dev_memmap() Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
    Re: [RFC PATCH 4/7] mm: register_dev_memmap() Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200
  [RFC PATCH 6/7] libnvdimm,  pfn: 'struct page' provider infrastructure Dan Williams <dan.j.williams@intel.com> - 2015-08-13 06:00 +0200
  Re: [RFC PATCH 0/7] 'struct page' driver for persistent memory Christoph Hellwig <hch@lst.de> - 2015-08-15 11:10 +0200

csiph-web