Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208076

Re: [PATCH] sched: sync with the cfs_rq when changing sched class

Show all headers | View raw

On Sat, Aug 15, 2015 at 01:24:12PM +0900, Byungchul Park wrote:
> On Fri, Aug 14, 2015 at 08:59:02PM +0800, T. Zhou wrote:
> > Hi,
> > 
> > On Thu, Aug 13, 2015 at 02:55:55PM +0900, byungchul.park@lge.com wrote:
> > > +static void attach_entity_load_avg(struct cfs_rq *cfs_rq, struct sched_entity *se)
> > > +{
> > > +	se->avg.last_update_time = cfs_rq->avg.last_update_time;
> > > +	cfs_rq->avg.load_avg += se->avg.load_avg;
> > > +	cfs_rq->avg.load_sum += se->avg.load_sum;
> > > +	cfs_rq->avg.util_avg += se->avg.util_avg;
> > > +	cfs_rq->avg.util_sum += se->avg.util_sum;
> > > +}
> > 
> > I see this function is used in enqueue_entity_load_avg() also.
> > In tip tree code, enqueue_entity_load_avg() uses cfs_rq_clock_task()
> > as se->last_update_time in migration condition.
> > Here, you use cfs_rq->avg.last_update_time as se->last_update_time.
> > If se->last_update_time is different, next decay may be different too.
> > Just from inspecting code, maybe some reasonable there?
> 
> hello zhou,
> 
> update_cfs_rq_load_avg() would update cfs_rq->avg.last_update_time to now,
> which is returned from cfs_rq_clock_task(). :)
> 
> thanks,
> byungchul
> 

Hi Byungchul,

yes, you are right. se and cfs_rq update load avg at same time. :)

thanks
-- 
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sched: sync with the cfs_rq when changing sched class byungchul.park@lge.com - 2015-08-13 08:00 +0200
  Re: [PATCH] sched: sync with the cfs_rq when changing sched class Yuyang Du <yuyang.du@intel.com> - 2015-08-13 08:40 +0200
    Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-13 09:20 +0200
      Re: [PATCH] sched: sync with the cfs_rq when changing sched class Yuyang Du <yuyang.du@intel.com> - 2015-08-13 12:30 +0200
  Re: [PATCH] sched: sync with the cfs_rq when changing sched class Peter Zijlstra <peterz@infradead.org> - 2015-08-13 09:50 +0200
    Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-13 10:30 +0200
      Re: [PATCH] sched: sync with the cfs_rq when changing sched class Yuyang Du <yuyang.du@intel.com> - 2015-08-13 12:10 +0200
        Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-13 13:00 +0200
        Re: [PATCH] sched: sync with the cfs_rq when changing sched class Peter Zijlstra <peterz@infradead.org> - 2015-08-13 17:30 +0200
          Re: [PATCH] sched: sync with the cfs_rq when changing sched class Yuyang Du <yuyang.du@intel.com> - 2015-08-14 09:20 +0200
            Re: [PATCH] sched: sync with the cfs_rq when changing sched class Peter Zijlstra <peterz@infradead.org> - 2015-08-14 10:50 +0200
          Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-15 09:00 +0200
            Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-15 09:20 +0200
    Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-13 10:50 +0200
  Re: [PATCH] sched: sync with the cfs_rq when changing sched class "T. Zhou" <t.s.zhou@hotmail.com> - 2015-08-14 15:20 +0200
    Re: [PATCH] sched: sync with the cfs_rq when changing sched class Byungchul Park <byungchul.park@lge.com> - 2015-08-15 06:30 +0200
      Re: [PATCH] sched: sync with the cfs_rq when changing sched class "T. Zhou" <t.s.zhou@hotmail.com> - 2015-08-15 14:50 +0200

csiph-web