Groups > linux.kernel > #1208036

Re: [PATCH] mm/memblock: validate the creation of debugfs files

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/memblock: validate the creation of debugfs files
Date	2015-08-15 10:00 +0200
Message-ID	<pXExI-3u1-7@gated-at.bofh.it> (permalink)
References	<pXswy-2Ca-17@gated-at.bofh.it> <pXuyl-5tV-7@gated-at.bofh.it> <pXE4G-2Wa-5@gated-at.bofh.it> <pXEel-37q-5@gated-at.bofh.it> <pXEo1-3iX-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 15 Aug 2015 13:48:50 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> On 08-15-15, Andrew Morton wrote:
> > Yes, I agree that if memblock's debugfs_create_file() fails, we want to
> > know about it because something needs fixing.  But that's true of
> > all(?) debugfs_create_file callsites, so it's a bit silly to add
> > warnings to them all.  Why not put the warning into
> > debugfs_create_file() itself?
> 
> Good idea, but there are already some debugfs_create_file calls with checks and
> warning, if these checks failed. I don't know how many, but I saw it.
> Double warning is not good too.

Please ponder the sentence you deleted.  "Or add a
debugfs_create_file_warn() wrapper".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-14 21:10 +0200
  Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-14 23:20 +0200
    Re: [PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-15 09:30 +0200
      Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-15 09:40 +0200
        Re: [PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-15 09:50 +0200
          Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-15 10:00 +0200
        Re: [PATCH] mm/memblock: validate the creation of debugfs files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 18:10 +0200
          Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-18 00:10 +0200

csiph-web