Groups > linux.kernel > #1208031

Re: [PATCH] mm/memblock: validate the creation of debugfs files

From	Alexander Kuleshov <kuleshovmail@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/memblock: validate the creation of debugfs files
Date	2015-08-15 09:30 +0200
Message-ID	<pXE4G-2Wa-5@gated-at.bofh.it> (permalink)
References	<pXswy-2Ca-17@gated-at.bofh.it> <pXuyl-5tV-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Andrew,

On 08-14-15, Andrew Morton wrote:
> On Sat, 15 Aug 2015 01:03:31 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:
> 
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> 
> There's no changelog.

Yes, will add it if there will be sense in the patch.

> 
> Why?  Ignoring the debugfs API return values is standard practice.
> 

Yes, but I saw many places where this practice is applicable (for example
in the kernel/kprobes and etc.), besides this, the memblock API is used
mostly at early stage, so we will have some output if something going wrong.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-14 21:10 +0200
  Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-14 23:20 +0200
    Re: [PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-15 09:30 +0200
      Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-15 09:40 +0200
        Re: [PATCH] mm/memblock: validate the creation of debugfs files Alexander Kuleshov <kuleshovmail@gmail.com> - 2015-08-15 09:50 +0200
          Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-15 10:00 +0200
        Re: [PATCH] mm/memblock: validate the creation of debugfs files Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-15 18:10 +0200
          Re: [PATCH] mm/memblock: validate the creation of debugfs files Andrew Morton <akpm@linux-foundation.org> - 2015-08-18 00:10 +0200

csiph-web