Groups > linux.kernel > #1205513

Re: [PATCH 1/4] rtc: s3c: add missing clk control

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] rtc: s3c: add missing clk control
Date	2015-08-12 02:10 +0200
Message-ID	<pWrMe-45O-11@gated-at.bofh.it> (permalink)
References	<pWfUJ-3Em-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11.08.2015 20:28, Joonyoung Shim wrote:
> It's missed to call clk_unprepare() about info->rtc_src_clk in
> s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in
> error routine of s3c_rtc_probe.
> 
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
>  drivers/rtc/rtc-s3c.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] rtc: s3c: add missing clk control Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-11 13:30 +0200
  [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-11 13:30 +0200
    Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of  clk Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-12 02:20 +0200
      Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of  clk Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-12 12:30 +0200
  Re: [PATCH 1/4] rtc: s3c: add missing clk control Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-12 02:10 +0200

csiph-web