Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205069

[PATCH 1/4] rtc: s3c: add missing clk control

Show all headers | View raw

It's missed to call clk_unprepare() about info->rtc_src_clk in
s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in
error routine of s3c_rtc_probe.

Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
 drivers/rtc/rtc-s3c.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index a0f8323..d1866a4 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -410,6 +410,8 @@ static int s3c_rtc_remove(struct platform_device *pdev)
 
 	s3c_rtc_setaie(info->dev, 0);
 
+	if (info->data->needs_src_clk)
+		clk_unprepare(info->rtc_src_clk);
 	clk_unprepare(info->rtc_clk);
 	info->rtc_clk = NULL;
 
@@ -482,6 +484,7 @@ static int s3c_rtc_probe(struct platform_device *pdev)
 		if (IS_ERR(info->rtc_src_clk)) {
 			dev_err(&pdev->dev,
 				"failed to find rtc source clock\n");
+			clk_disable_unprepare(info->rtc_clk);
 			return PTR_ERR(info->rtc_src_clk);
 		}
 		clk_prepare_enable(info->rtc_src_clk);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] rtc: s3c: add missing clk control Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-11 13:30 +0200
  [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-11 13:30 +0200
    Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of  clk Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-12 02:20 +0200
      Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of  clk Joonyoung Shim <jy0922.shim@samsung.com> - 2015-08-12 12:30 +0200
  Re: [PATCH 1/4] rtc: s3c: add missing clk control Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-12 02:10 +0200

csiph-web