Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1205183
| From | Jiri Olsa <jolsa@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error |
| Date | 2015-08-11 16:40 +0200 |
| Message-ID | <pWiSB-7UI-15@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <pV0O6-fI-19@gated-at.bofh.it> <pWhtw-5ZS-35@gated-at.bofh.it> <pWhDc-6bn-1@gated-at.bofh.it> <pWhMS-6mR-15@gated-at.bofh.it> <pWi6d-6Jq-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Aug 11, 2015 at 06:40:27AM -0700, Andi Kleen wrote:
> On Tue, Aug 11, 2015 at 03:24:27PM +0200, Jiri Olsa wrote:
> > On Tue, Aug 11, 2015 at 06:14:57AM -0700, Andi Kleen wrote:
> > > > Which attribute parsing is failing for you?
> > >
> > > The new .agg-per-core attribute I added later in the series.
> > > I think it will happen to any not-yet-known attribute.
> >
> > alias can contain only terms defined in formats directory,
> > and the *.XXX attributes parsing does not return error code
> >
> > can't see the failure, please get some example
>
> Apply the kernel patch that adds several .agg-per-core attributes
> Then try to use any cpu/.../ event
>
> % perf stat -e cpu/event=0x3c/ true
> invalid or unsupported event: 'cpu/event=0x3c/'
>
> because the PMU parsing bailed out.
ugh right, the new attribute wont be recognized..
how about recognizing attribute based on the '.' prefix being
existing file rather than the suffix like in the attached patch
jirka
---
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index d4b0e6454bc6..937ecc35a60e 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -258,21 +258,23 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI
return __perf_pmu__new_alias(list, dir, name, NULL, buf);
}
-static inline bool pmu_alias_info_file(char *name)
+static inline bool pmu_alias_attr_file(char *dir, char *name)
{
- size_t len;
-
- len = strlen(name);
- if (len > 5 && !strcmp(name + len - 5, ".unit"))
- return true;
- if (len > 6 && !strcmp(name + len - 6, ".scale"))
- return true;
- if (len > 8 && !strcmp(name + len - 8, ".per-pkg"))
- return true;
- if (len > 9 && !strcmp(name + len - 9, ".snapshot"))
- return true;
+ bool ret = false;
+ struct stat st;
+ char *path, *s;
- return false;
+ if (asprintf(&path, "%s/%s", dir, name) == -1)
+ return false;
+
+ s = strrchr(path, '.');
+ if (s) {
+ *s = 0;
+ ret = !stat(path, &st);
+ }
+
+ free(path);
+ return ret;
}
/*
@@ -300,7 +302,7 @@ static int pmu_aliases_parse(char *dir, struct list_head *head)
/*
* skip info files parsed in perf_pmu__new_alias()
*/
- if (pmu_alias_info_file(name))
+ if (pmu_alias_attr_file(dir, name))
continue;
snprintf(path, PATH_MAX, "%s/%s", dir, name);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
[PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:10 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:20 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:30 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:50 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 16:40 +0200
Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:00 +0200
[PATCH 7/9] x86, perf: Add Top Down events to Intel Atom Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
[PATCH 3/9] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
[PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:30 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:40 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 16:00 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:10 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 19:20 +0200
Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:20 +0200
[PATCH 5/9] x86, perf: Support sysfs files depending on SMT status Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
[PATCH 6/9] x86, perf: Add Top Down events to Intel Core Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
[PATCH 8/9] perf, tools, stat: Add extra output of counter values with -v Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
csiph-web