Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205125

Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error

Show all headers | View raw

On Fri, Aug 07, 2015 at 06:06:17PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> When an error happens during alias parsing currently the complete
> parsing of all attributes of the PMU is stopped. This is breaks
> old perf on a newer kernel that may have not-yet-know
> alias attributes (such as .scale or .per-pkg).

hum, both .scale and .per-pgk are skip from term parsing via:

                /*
                 * skip info files parsed in perf_pmu__new_alias()
                 */
                if (pmu_alias_info_file(name))
                        continue;

and loaded without any error report:

	static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
					 char *desc __maybe_unused, char *val)
	SNIP
		if (dir) {
			/*
			 * load unit name and scale if available
			 */
			perf_pmu__parse_unit(alias, dir, name);
			perf_pmu__parse_scale(alias, dir, name);
			perf_pmu__parse_per_pkg(alias, dir, name);
			perf_pmu__parse_snapshot(alias, dir, name);
		}

		list_add_tail(&alias->list, list);

		return 0;
	}

Which attribute parsing is failing for you?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Add top down metrics to perf stat Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
  [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse error Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
    Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:10 +0200
      Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:20 +0200
        Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:30 +0200
          Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:50 +0200
            Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Jiri Olsa <jolsa@redhat.com> - 2015-08-11 16:40 +0200
              Re: [PATCH 1/9] perf, tools: Dont stop PMU parsing on alias parse  error Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:00 +0200
  [PATCH 7/9] x86, perf: Add Top Down events to Intel Atom Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
  [PATCH 3/9] perf, tools, stat: Basic support for TopDown in perf stat Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
  [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
    Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 15:30 +0200
      Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <ak@linux.intel.com> - 2015-08-11 15:40 +0200
        Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 16:00 +0200
          Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:10 +0200
            Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Jiri Olsa <jolsa@redhat.com> - 2015-08-11 19:20 +0200
              Re: [PATCH 2/9] perf, tools, stat: Support up-scaling of events Andi Kleen <andi@firstfloor.org> - 2015-08-11 19:20 +0200
  [PATCH 5/9] x86, perf: Support sysfs files depending on SMT status Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
  [PATCH 6/9] x86, perf: Add Top Down events to Intel Core Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200
  [PATCH 8/9] perf, tools, stat: Add extra output of counter values with -v Andi Kleen <andi@firstfloor.org> - 2015-08-08 03:10 +0200

csiph-web