Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204295

Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties.

Show all headers | View raw

On 10/08/15 14:26, Thierry Reding wrote:
> On Mon, Aug 10, 2015 at 02:15:18PM +0100, Srinivas Kandagatla wrote:
>>
>>
>> On 10/08/15 13:38, Thierry Reding wrote:
>>> On Mon, Aug 10, 2015 at 12:59:34PM +0100, Srinivas Kandagatla wrote:
>>>> This patch modifies the driver to support standard gpio properties along
>>>> with deprecated properties. This will help us upstream and cleanup the
>>>> non-standard properties over the time.
>>>>
>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>>>> ---
>>>>   drivers/gpu/drm/msm/hdmi/hdmi.c | 35 +++++++++++++++++++++++++----------
>>>>   1 file changed, 25 insertions(+), 10 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
>>>> index 8145362..e918889 100644
>>>> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
>>>> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
>>>> @@ -339,19 +339,34 @@ static const struct of_device_id dt_match[] = {
>>>>   };
>>>>
>>>>   #ifdef CONFIG_OF
>>>> +/* This code will be removed once we move to gpiod based calls */
>>>
>>> Why don't you do this now instead of duplicating what is essentially
>>> already implemented in gpiolib?
>>>
>> One of the thing that Rob asked in his comments
>> (http://www.spinics.net/lists/arm-kernel/msg437675.html) was to retain the
>> support for old devices, moving to gpiod ATM would break such devices as
>> they are still using legacy gpiolib and its naming.
>>
>>
>> If Rob is ok to drop gpio properties which does not have "-gpio" or "-gpios"
>> suffix then we can get rid of this function all together.
>
> If you make the switch to gpiod_*() APIs you'll get this for free.
> There's really no need for having a duplicate of what gpiod_get()
> already does for you.
>
Yes, you are right, my memory was over written on friday by looking at 
of_find_gpio() for long :-)

AFAIK, gpiod_get would also request the gpios so we might want to remove 
the additional gpio requests in the hdmi_connector.c too.

I will give that a try once again..

--srini
> Thierry
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 0/5] drm/msm/hdmi: DT bindings cleanup Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
  [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
    Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 14:40 +0200
      Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:20 +0200
        Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:30 +0200
          Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 16:00 +0200
  [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
    Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 14:50 +0200
      Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Rob Herring <robherring2@gmail.com> - 2015-08-11 00:10 +0200
        Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio  properties. Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-11 00:30 +0200
          Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Rob Clark <robdclark@gmail.com> - 2015-08-11 02:30 +0200
  [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:10 +0200
    Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:00 +0200
      Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:20 +0200
        Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:40 +0200
          Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:50 +0200
  [PATCH RFC 5/5] drm/msm/hdmi: remove _clk suffix from clock names. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:10 +0200

csiph-web