Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1204225

Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Aug 10, 2015 at 12:59:22PM +0100, Srinivas Kandagatla wrote:
> This patch updates the bindings to discourage the usage of non standard
> gpio properites, this will help in projects focused on upstreaming.

That last part is an odd comment to make in the commit message of a
patch submitted upstream...

> These deprecated properties are still supported but will be remove over
> the time.

You can't ever remove them because you can't ever be sure that people
won't be using an old DTB.

> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  Documentation/devicetree/bindings/drm/msm/hdmi.txt | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/drm/msm/hdmi.txt b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> index c43aa53..acba581 100644
> --- a/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> +++ b/Documentation/devicetree/bindings/drm/msm/hdmi.txt
> @@ -11,15 +11,27 @@ Required properties:
>  - interrupts: The interrupt signal from the hdmi block.
>  - clocks: device clocks
>    See ../clocks/clock-bindings.txt for details.
> -- qcom,hdmi-tx-ddc-clk-gpio: ddc clk pin
> -- qcom,hdmi-tx-ddc-data-gpio: ddc data pin
> -- qcom,hdmi-tx-hpd-gpio: hpd pin
> +- qcom,hdmi-tx-ddc-clk-gpios: ddc clk pin
> +- qcom,hdmi-tx-ddc-data-gpios: ddc data pin
> +- qcom,hdmi-tx-hpd-gpios: hpd pin
>  - core-vdda-supply: phandle to supply regulator
>  - hdmi-mux-supply: phandle to mux regulator
>  
> +- qcom,hdmi-tx-ddc-clk-gpio: (deprecated) use
> +	"qcom,hdmi-tx-ddc-clk-gpios" instead
> +- qcom,hdmi-tx-ddc-data-gpio: (deprecated) use
> +	"qcom,hdmi-tx-ddc-data-gpios" instead
> +- qcom,hdmi-tx-hpd-gpio: (deprecated) use
> +	"qcom,hdmi-tx-hpd-gpios" instead
> +
>  Optional properties:
> -- qcom,hdmi-tx-mux-en-gpio: hdmi mux enable pin
> -- qcom,hdmi-tx-mux-sel-gpio: hdmi mux select pin
> +- qcom,hdmi-tx-mux-en-gpios: hdmi mux enable pin
> +- qcom,hdmi-tx-mux-sel-gpios: hdmi mux select pin
> +
> +- qcom,hdmi-tx-mux-en-gpio: (deprecated) use "qcom,hdmi-tx-mux-en-gpios"
> +	instead
> +- qcom,hdmi-tx-mux-sel-gpio: (deprecated) use "qcom,hdmi-tx-mux-sel-gpio"
> +	instead
>  - pinctrl-names: the pin control state names; should contain "default"
>  - pinctrl-0: the default pinctrl state (active)
>  - pinctrl-1: the "sleep" pinctrl state

I don't see much use in listing that these properties are deprecated. We
already have code to catch the deprecated names, so having them in the
binding will at best be distracting.

Anyway, I don't know if there's been any advice on this from the device
tree bindings maintainers, so adding devicetree@vger.kernel.org for
visibility.

Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 0/5] drm/msm/hdmi: DT bindings cleanup Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
  [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
    Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 14:40 +0200
      Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:20 +0200
        Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:30 +0200
          Re: [PATCH RFC 2/5] drm/msm/hdmi: make use of standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 16:00 +0200
  [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:00 +0200
    Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio  properties. Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 14:50 +0200
      Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Rob Herring <robherring2@gmail.com> - 2015-08-11 00:10 +0200
        Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio  properties. Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-08-11 00:30 +0200
          Re: [PATCH RFC 1/5] drm/msm/hdmi: deprecate non standard gpio properties. Rob Clark <robdclark@gmail.com> - 2015-08-11 02:30 +0200
  [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:10 +0200
    Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:00 +0200
      Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:20 +0200
        Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Thierry Reding <thierry.reding@gmail.com> - 2015-08-10 15:40 +0200
          Re: [PATCH RFC 4/5] drm/msm/hdmi: deprecate non standard clock-names Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 15:50 +0200
  [PATCH RFC 5/5] drm/msm/hdmi: remove _clk suffix from clock names. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 14:10 +0200

csiph-web