Groups > linux.kernel > #1203891

Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock

From	Shunqian Zheng <zhengsq@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock
Date	2015-08-10 10:40 +0200
Message-ID	<pVQMF-IF-1@gated-at.bofh.it> (permalink)
References	<pVLWF-1rK-3@gated-at.bofh.it> <pVLWG-1rK-7@gated-at.bofh.it> <pVQjE-9c-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

On 2015年08月10日 16:08, Heiko Stübner wrote:
> Hi,
>
> Am Montag, 10. August 2015, 11:22:43 schrieb Shunqian Zheng:
>> From: ZhengShunQian <zhengsq@rock-chips.com>
>>
>> Always enable the clock of efuse256. Base on the nvmem framework,
>> it seems like there is not a good way to enable the clock
>> when actual needed.
>>
>> Signed-off-by: ZhengShunQian <zhengsq@rock-chips.com>
> actually regmap already provides a handle to have a clock for mmio-based
> regmaps ... take a look at devm_regmap_init_mmio_clk() [0]
Srinivas also suggested devm_regmap_init_mmio_clk() too, but unfortunately
mmio uses its own .read/.write callback that not suitable for eFuse.
>
> If this doesn't help, you can also simply clk_get and clk_prepare_enable the
> clock in your rockchip_efuse_probe() and disable in rockchip_efuse_remove().
Sure, I will use this way.
Thank you!!
>
>
> But I certainly don't want to extend the range of clocks magically staying
> enabled through the ccf.
>
>
> Heiko
>
>
> [0] http://lxr.free-electrons.com/source/drivers/base/regmap/regmap-mmio.c#L336
>
>
>> ---
>>   drivers/clk/rockchip/clk-rk3288.c      | 2 +-
>>   include/dt-bindings/clock/rk3288-cru.h | 1 +
>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/rockchip/clk-rk3288.c
>> b/drivers/clk/rockchip/clk-rk3288.c index 0df5bae..84d9218 100644
>> --- a/drivers/clk/rockchip/clk-rk3288.c
>> +++ b/drivers/clk/rockchip/clk-rk3288.c
>> @@ -647,7 +647,7 @@ static struct rockchip_clk_branch rk3288_clk_branches[]
>> __initdata = { GATE(0, "pclk_efuse_1024", "pclk_cpu", 0,
>> RK3288_CLKGATE_CON(11), 2, GFLAGS), GATE(PCLK_TZPC, "pclk_tzpc",
>> "pclk_cpu", 0, RK3288_CLKGATE_CON(11), 3, GFLAGS), GATE(PCLK_UART2,
>> "pclk_uart2", "pclk_cpu", 0, RK3288_CLKGATE_CON(11), 9, GFLAGS), -	GATE(0,
>> "pclk_efuse_256", "pclk_cpu", 0, RK3288_CLKGATE_CON(11), 10, GFLAGS),
>> +	GATE(PCLK_EFUSE256, "pclk_efuse_256", "pclk_cpu", CLK_IGNORE_UNUSED,
>> RK3288_CLKGATE_CON(11), 10, GFLAGS), GATE(PCLK_RKPWM, "pclk_rkpwm",
>> "pclk_cpu", CLK_IGNORE_UNUSED, RK3288_CLKGATE_CON(11), 11, GFLAGS),
>>
>>   	/* ddrctrl [DDR Controller PHY clock] gates */
>> diff --git a/include/dt-bindings/clock/rk3288-cru.h
>> b/include/dt-bindings/clock/rk3288-cru.h index c719aac..ab74d5e 100644
>> --- a/include/dt-bindings/clock/rk3288-cru.h
>> +++ b/include/dt-bindings/clock/rk3288-cru.h
>> @@ -164,6 +164,7 @@
>>   #define PCLK_DDRUPCTL1		366
>>   #define PCLK_PUBL1		367
>>   #define PCLK_WDT		368
>> +#define PCLK_EFUSE256		369
>>
>>   /* hclk gates */
>>   #define HCLK_GPS		448
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/3] Add eFuse driver of Rockchip SoC Shunqian Zheng <zhengsq@rock-chips.com> - 2015-08-10 05:30 +0200
  [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock Shunqian Zheng <zhengsq@rock-chips.com> - 2015-08-10 05:30 +0200
    Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock Heiko Stübner <heiko@sntech.de> - 2015-08-10 10:10 +0200
      Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock Shunqian Zheng <zhengsq@rock-chips.com> - 2015-08-10 10:40 +0200
    Re: [PATCH 3/3] clk: rockchip: do not gate the efuse256 clock Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 10:50 +0200
  [PATCH 1/3] nvmem: fix the out-of-range leak in read/write() Shunqian Zheng <zhengsq@rock-chips.com> - 2015-08-10 05:30 +0200
    Re: [PATCH 1/3] nvmem: fix the out-of-range leak in read/write() Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 10:50 +0200
  [PATCH 2/3] nvmem: rockchip-efuse: implement eFuse driver Shunqian Zheng <zhengsq@rock-chips.com> - 2015-08-10 05:30 +0200
    Re: [PATCH 2/3] nvmem: rockchip-efuse: implement eFuse driver Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2015-08-10 11:00 +0200

csiph-web