Groups > linux.kernel > #1201968

Re: [PATCH V5] audit: use macros for unset inode and device values

From	Paul Moore <pmoore@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5] audit: use macros for unset inode and device values
Date	2015-08-06 20:40 +0200
Message-ID	<pUyf8-oA-13@gated-at.bofh.it> (permalink)
References	<pUdu3-3Ci-21@gated-at.bofh.it> <pUeTa-5wN-59@gated-at.bofh.it> <pUklP-54X-7@gated-at.bofh.it>
Organization	Red Hat

Show all headers | View raw

On Wednesday, August 05, 2015 11:40:34 PM Richard Guy Briggs wrote:
> On 15/08/05, Paul Moore wrote:
> > I suspect it was lost in the noise when I mentioned it on v4, but how
> > about changing AUDIT_DEV_UNSET to "(dev_t)-1"?
> 
> I saw your comment only after resubmitting.  I'm fine either way.  If it
> is needed for uapi later it can be changed then.  Is it easy to change
> in your workflow, or should I resubmit?  I know you routinely change the
> patch description, but could not remember if you have actually changed
> the patch itself...

With the exception of trivial merge conflicts, in general I like to avoid 
changing the body of the patches when I apply them; there are always going to 
be exceptions, but when possible I try to avoid it.  I consider tweaking the 
patch subject lines pretty trivial, especially in the last case where the 
subject line had become wrong/invalid due to changes in the patch itself.

-- 
paul moore
security @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5] audit: use macros for unset inode and device values Richard Guy Briggs <rgb@redhat.com> - 2015-08-05 22:30 +0200
  Re: [PATCH V5] audit: use macros for unset inode and device values Paul Moore <pmoore@redhat.com> - 2015-08-06 00:00 +0200
    Re: [PATCH V5] audit: use macros for unset inode and device values Richard Guy Briggs <rgb@redhat.com> - 2015-08-06 05:50 +0200
      Re: [PATCH V5] audit: use macros for unset inode and device values Paul Moore <pmoore@redhat.com> - 2015-08-06 20:40 +0200

csiph-web