Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1201197
| From | Paul Moore <pmoore@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V5] audit: use macros for unset inode and device values |
| Date | 2015-08-06 00:00 +0200 |
| Message-ID | <pUeTa-5wN-59@gated-at.bofh.it> (permalink) |
| References | <pUdu3-3Ci-21@gated-at.bofh.it> |
| Organization | Red Hat |
On Wednesday, August 05, 2015 04:19:09 PM Richard Guy Briggs wrote: > Clean up a number of places were casted magic numbers are used to represent > unset inode and device numbers in preparation for the audit by executable > path patch set. > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com> > --- > v5: Move macros from include/uapi/linux/audit.h to include/linux/audit.h > Use "unsigned int" rather than bare "unsigned". > > include/linux/audit.h | 3 +++ > kernel/audit.c | 2 +- > kernel/audit_watch.c | 8 ++++---- > kernel/auditsc.c | 6 +++--- > 4 files changed, 11 insertions(+), 8 deletions(-) > > diff --git a/include/linux/audit.h b/include/linux/audit.h > index c2e7e3a..48ae90c 100644 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -27,6 +27,9 @@ > #include <linux/ptrace.h> > #include <uapi/linux/audit.h> > > +#define AUDIT_INO_UNSET (unsigned long)-1 > +#define AUDIT_DEV_UNSET (unsigned int)-1 I suspect it was lost in the noise when I mentioned it on v4, but how about changing AUDIT_DEV_UNSET to "(dev_t)-1"? -- paul moore security @ redhat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V5] audit: use macros for unset inode and device values Richard Guy Briggs <rgb@redhat.com> - 2015-08-05 22:30 +0200
Re: [PATCH V5] audit: use macros for unset inode and device values Paul Moore <pmoore@redhat.com> - 2015-08-06 00:00 +0200
Re: [PATCH V5] audit: use macros for unset inode and device values Richard Guy Briggs <rgb@redhat.com> - 2015-08-06 05:50 +0200
Re: [PATCH V5] audit: use macros for unset inode and device values Paul Moore <pmoore@redhat.com> - 2015-08-06 20:40 +0200
csiph-web