Groups > linux.kernel > #1201056

Re: [PATCH] thermal: power_allocator: do not use devm* interfaces

Path	csiph.com!goblin3!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Eduardo Valentin <edubezval@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: power_allocator: do not use devm* interfaces
Date	Wed, 05 Aug 2015 20:50:01 +0200
Message-ID	<pUbVf-1gF-5@gated-at.bofh.it> (permalink)
References	<pTNpT-7C4-1@gated-at.bofh.it> <pU2fg-4cC-15@gated-at.bofh.it> <pUacO-7dQ-19@gated-at.bofh.it> <pUaFR-811-29@gated-at.bofh.it>
X-Original-To	Javi Merino <javi.merino@arm.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3tUzTQNg41RlgkHgnJiRK2pVKHh8xSbavGrb0VeXGe8=; b=cQ8gei8noqGtBzJYV9Z2ZbijnmqrJUc+AtVQbD9YarUpDAynW7/kK/NyjfIyHYkZPg rokPAHTNujCCaL3Tuw/pdDhzr0PkVdRnzdRExcdQ3q/1UQMW+yuL5daJJ9nZdkLgZTSL 3WcLQr/NobtAcznPwuuU+w2KRLStVuS5dZxg8iuBzXrgtxgxduXcWK38jeXq6PqhGoe6 qlvb0tnzQ46VCQXJzyLo8Ky0JUc303pAcV/tiEiuKqxdj33d1swOf9+yvC2LYWuO442Q U8BUP82vGN9zl4ndYv59+QY959Y6ATpKWexqz7Q+p/porrxlEYpIZ0X27vTMfbbtYLVL 6VQw==
X-Received	by 10.70.90.230 with SMTP id bz6mr21937923pdb.120.1438800251279; Wed, 05 Aug 2015 11:44:11 -0700 (PDT)
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s/l3CgOIzMHHjg/5"
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	70
Organization	linux.* mail to news gateway
X-Original-Cc	Dmitry Torokhov <dmitry.torokhov@gmail.com>, Zhang Rui <rui.zhang@intel.com>, Lukasz Majewski <l.majewski@samsung.com>, Peter Feuerer <peter@piie.net>, Sascha Hauer <s.hauer@pengutronix.de>, Punit Agrawal <Punit.Agrawal@arm.com>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 5 Aug 2015 11:44:06 -0700
X-Original-Message-ID	<20150805184405.GB4161@localhost.localdomain>
X-Original-References	<20150804163340.GA33245@dtor-ws> <20150805082910.GB2688@e104805> <20150805165020.GB3603@dtor-ws> <20150805172902.GE2688@e104805>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1201056

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 05, 2015 at 06:29:03PM +0100, Javi Merino wrote:
> On Wed, Aug 05, 2015 at 05:50:20PM +0100, Dmitry Torokhov wrote:
> > On Wed, Aug 05, 2015 at 09:29:11AM +0100, Javi Merino wrote:
> > > On Tue, Aug 04, 2015 at 05:33:40PM +0100, Dmitry Torokhov wrote:
> > > > The code in question is called outside of standard driver
> > > > probe()/remove() callbacks and thus will not benefit from use of devm*
> > > > infrastructure.
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > 
> > > We added the devm* calls because Eduardo asked for them in the review.
> > > I don't have a strong opinion regarding this, I'll leave the decision
> > > to Eduardo.
> > 
> > I tried to look for his reasons, if any, but even in earliest posted
> > versions use devm* for allocating memory
> 
> http://thread.gmane.org/gmane.linux.power-management.general/45000/focus=45265
> http://thread.gmane.org/gmane.linux.power-management.general/46064/focus=1722858
> 
> He didn't give reasons and I didn't ask for them.  He insisted on it so I just added
> it across the board.

Yeah, that's my bad.

I believe I had in mind getting the thermal core in a better shape by
having proper driver/device matching. But still, looking at the code
now, I must agree with Dmitry. As of now, it does not make sense.


BR,

Eduardo

> 
> Cheers,
> Javi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: power_allocator: do not use devm* interfaces Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-04 18:40 +0200
  Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Javi Merino <javi.merino@arm.com> - 2015-08-05 10:30 +0200
    Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-05 19:00 +0200
      Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Javi Merino <javi.merino@arm.com> - 2015-08-05 19:30 +0200
        Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Eduardo Valentin <edubezval@gmail.com> - 2015-08-05 20:50 +0200

csiph-web