Groups > linux.kernel > #1201056

Re: [PATCH] thermal: power_allocator: do not use devm* interfaces

From	Eduardo Valentin <edubezval@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thermal: power_allocator: do not use devm* interfaces
Date	2015-08-05 20:50 +0200
Message-ID	<pUbVf-1gF-5@gated-at.bofh.it> (permalink)
References	<pTNpT-7C4-1@gated-at.bofh.it> <pU2fg-4cC-15@gated-at.bofh.it> <pUacO-7dQ-19@gated-at.bofh.it> <pUaFR-811-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Aug 05, 2015 at 06:29:03PM +0100, Javi Merino wrote:
> On Wed, Aug 05, 2015 at 05:50:20PM +0100, Dmitry Torokhov wrote:
> > On Wed, Aug 05, 2015 at 09:29:11AM +0100, Javi Merino wrote:
> > > On Tue, Aug 04, 2015 at 05:33:40PM +0100, Dmitry Torokhov wrote:
> > > > The code in question is called outside of standard driver
> > > > probe()/remove() callbacks and thus will not benefit from use of devm*
> > > > infrastructure.
> > > > 
> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > 
> > > We added the devm* calls because Eduardo asked for them in the review.
> > > I don't have a strong opinion regarding this, I'll leave the decision
> > > to Eduardo.
> > 
> > I tried to look for his reasons, if any, but even in earliest posted
> > versions use devm* for allocating memory
> 
> http://thread.gmane.org/gmane.linux.power-management.general/45000/focus=45265
> http://thread.gmane.org/gmane.linux.power-management.general/46064/focus=1722858
> 
> He didn't give reasons and I didn't ask for them.  He insisted on it so I just added
> it across the board.

Yeah, that's my bad.

I believe I had in mind getting the thermal core in a better shape by
having proper driver/device matching. But still, looking at the code
now, I must agree with Dmitry. As of now, it does not make sense.


BR,

Eduardo

> 
> Cheers,
> Javi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thermal: power_allocator: do not use devm* interfaces Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-04 18:40 +0200
  Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Javi Merino <javi.merino@arm.com> - 2015-08-05 10:30 +0200
    Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-05 19:00 +0200
      Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Javi Merino <javi.merino@arm.com> - 2015-08-05 19:30 +0200
        Re: [PATCH] thermal: power_allocator: do not use devm* interfaces Eduardo Valentin <edubezval@gmail.com> - 2015-08-05 20:50 +0200

csiph-web