Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1202971

[PATCH V3 1/1] zram: Remove useless check

From Salah Triki <salah.triki@acm.org>
Newsgroups linux.kernel
Subject [PATCH V3 1/1] zram: Remove useless check
Date 2015-08-07 20:10 +0200
Message-ID <pUUfF-7bJ-37@gated-at.bofh.it> (permalink)
References <pUUfE-7bJ-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


lzo1x_1_compress always returns LZO_E_OK that is equal to 0. Thus, the
check of the return value is useless.

Signed-off-by: Salah Triki <salah.triki@acm.org>
---
 drivers/block/zram/zcomp_lzo.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/zram/zcomp_lzo.c b/drivers/block/zram/zcomp_lzo.c
index da1bc47..3cf30c9 100644
--- a/drivers/block/zram/zcomp_lzo.c
+++ b/drivers/block/zram/zcomp_lzo.c
@@ -26,8 +26,7 @@ static void lzo_destroy(void *private)
 static int lzo_compress(const unsigned char *src, unsigned char *dst,
 		size_t *dst_len, void *private)
 {
-	int ret = lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
-	return ret == LZO_E_OK ? 0 : ret;
+	return lzo1x_1_compress(src, PAGE_SIZE, dst, dst_len, private);
 }
 
 static int lzo_decompress(const unsigned char *src, size_t src_len,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V3 0/1] zram: Remove useless check Salah Triki <salah.triki@acm.org> - 2015-08-07 20:10 +0200
  [PATCH V3 1/1] zram: Remove useless check Salah Triki <salah.triki@acm.org> - 2015-08-07 20:10 +0200
    Re: [PATCH V3 1/1] zram: Remove useless check Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-10 02:10 +0200

csiph-web