Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202438

[PATCH 10/31] clk/mmp: use kmemdup rather than duplicating its implementation

Show all headers | View raw

The patch was generated using fixed coccinelle semantic patch
scripts/coccinelle/api/memdup.cocci [1].

[1]: http://permalink.gmane.org/gmane.linux.kernel/2014320

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
 drivers/clk/mmp/clk-mix.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c
index 665cb67..3383410 100644
--- a/drivers/clk/mmp/clk-mix.c
+++ b/drivers/clk/mmp/clk-mix.c
@@ -469,20 +469,20 @@ struct clk *mmp_clk_register_mix(struct device *dev,
 	memcpy(&mix->reg_info, &config->reg_info, sizeof(config->reg_info));
 	if (config->table) {
 		table_bytes = sizeof(*config->table) * config->table_size;
-		mix->table = kzalloc(table_bytes, GFP_KERNEL);
+		mix->table = kmemdup(config->table, table_bytes, GFP_KERNEL);
 		if (!mix->table) {
 			pr_err("%s:%s: could not allocate mmp mix table\n",
 				__func__, name);
 			kfree(mix);
 			return ERR_PTR(-ENOMEM);
 		}
-		memcpy(mix->table, config->table, table_bytes);
 		mix->table_size = config->table_size;
 	}
 
 	if (config->mux_table) {
 		table_bytes = sizeof(u32) * num_parents;
-		mix->mux_table = kzalloc(table_bytes, GFP_KERNEL);
+		mix->mux_table = kmemdup(config->mux_table, table_bytes,
+					 GFP_KERNEL);
 		if (!mix->mux_table) {
 			pr_err("%s:%s: could not allocate mmp mix mux-table\n",
 				__func__, name);
@@ -490,7 +490,6 @@ struct clk *mmp_clk_register_mix(struct device *dev,
 			kfree(mix);
 			return ERR_PTR(-ENOMEM);
 		}
-		memcpy(mix->mux_table, config->mux_table, table_bytes);
 	}
 
 	mix->div_flags = config->div_flags;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/31] use kmemdup rather than duplicating its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:10 +0200
  [PATCH 31/31] sound/soc: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:10 +0200
  [PATCH 08/31] arch/x86/intel-mid: use kmemdup rather than duplicating  its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:10 +0200
  [PATCH 25/31] fs/ubifs: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:10 +0200
    Re: [PATCH 25/31] fs/ubifs: use kmemdup rather than duplicating its implementation Richard Weinberger <richard.weinberger@gmail.com> - 2015-08-08 11:20 +0200
    Re: [PATCH 25/31] fs/ubifs: use kmemdup rather than duplicating its  implementation Artem Bityutskiy <dedekind1@gmail.com> - 2015-08-10 10:20 +0200
  [PATCH 03/31] arch/m68k/bootinfo: use kmemdup rather than duplicating  its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 03/31] arch/m68k/bootinfo: use kmemdup rather than  duplicating its implementation Geert Uytterhoeven <geert@linux-m68k.org> - 2015-08-07 12:30 +0200
  [PATCH 06/31] arch/powerpc/pseries: use kmemdup rather than  duplicating its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 06/31] arch/powerpc/pseries: use kmemdup rather than duplicating  its implementation Nathan Fontenot <nfont@linux.vnet.ibm.com> - 2015-08-07 21:50 +0200
  [PATCH 22/31] fs/ntfs: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 04/31] arch/mips/bcm47xx: use kmemdup rather than duplicating  its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 04/31] arch/mips/bcm47xx: use kmemdup rather than duplicating  its implementation Hauke Mehrtens <hauke@hauke-m.de> - 2015-08-09 22:20 +0200
  [PATCH 14/31] message/fusion: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 12/31] drm/amdgpu: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 15/31] misc/vmw_vmci: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 17/31] scsi/aacraid: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 18/31] scsi/aic7xxx: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
  [PATCH 05/31] arch/powerpc/nvram: use kmemdup rather than duplicating  its implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 05/31] arch/powerpc/nvram: use kmemdup rather than duplicating  its implementation Nathan Fontenot <nfont@linux.vnet.ibm.com> - 2015-08-07 21:50 +0200
  [PATCH 10/31] clk/mmp: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 10/31] clk/mmp: use kmemdup rather than duplicating its  implementation Stephen Boyd <sboyd@codeaurora.org> - 2015-08-08 00:20 +0200
  [PATCH 11/31] cpufreq/sfi: use kmemdup rather than duplicating its  implementation Andrzej Hajda <a.hajda@samsung.com> - 2015-08-07 10:20 +0200
    Re: [PATCH 11/31] cpufreq/sfi: use kmemdup rather than duplicating  its implementation Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-07 11:00 +0200

csiph-web