Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202183

Re: [PATCH 0/3] zram: Replace pr_* with dev_*

Show all headers | View raw

On Fri, 2015-08-07 at 09:05 +0900, Sergey Senozhatsky wrote:
> On (08/07/15 00:03), Salah Triki wrote:
> > This patchset replaces pr_* with dev_*. dev_* attach kernel messages to the right
> > device. In addition, patchs 1 and 2 add to messages the values of variables that trigger 
> > errors.
[]
> I'd prefer to leave the messages the way they are. Changing anything
> visible to user space (api, eror codes, error messages, etc.) is a
> very risky business. You change the format of error messages and it
> smells like a big NO-NO.
> 
> 'zram: Cannot initialise lzo compressing backend'
> --> 'block zram0: Cannot initialise lzo compressing backend'
> 
> 
> And there are even more dramatic changes:
> "Cannot change max compression streams\n"
> --> "Cannot change max compression streams to %d\n"
> 
> "Can't change algorithm for initialized device\n"
> --> "Can't change algorithm to %s for initialized device\n"
> 
> 
> People already can have scripts doing `grep "zram:"` on dmesg or
> whatever. We cannot change this anymore.

That's not true at all.

Using grep on dmesg is specifically _not_ guaranteed
to remain stable between kernel versions.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] zram: Replace pr_* with dev_* Salah Triki <salah.triki@acm.org> - 2015-08-07 01:00 +0200
  [PATCH 3/3] zram: Replace pr_* with dev_* Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  [PATCH 2/3] zram: Replace pr_info with dev_info in comp_algorithm_store Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  [PATCH 1/3] zram: Replace pr_info with dev_info in max_comp_streams_store Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 02:10 +0200
    Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 03:20 +0200
      Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 03:50 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 03:50 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 04:10 +0200
            Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 04:20 +0200
    Re: [PATCH 0/3] zram: Replace pr_* with dev_* Minchan Kim <minchan@kernel.org> - 2015-08-07 08:10 +0200
      Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 08:40 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 09:00 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 09:20 +0200
            Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 09:30 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Minchan Kim <minchan@kernel.org> - 2015-08-07 17:00 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-10 03:30 +0200

csiph-web