Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1202195

Re: [PATCH 0/3] zram: Replace pr_* with dev_*

Show all headers | View raw

Hello Joe,

On (08/06/15 18:17), Joe Perches wrote:
[..]
> > "Can't change algorithm for initialized device\n"
> > --> "Can't change algorithm to %s for initialized device\n"
> > 
> > 
> > People already can have scripts doing `grep "zram:"` on dmesg or
> > whatever. We cannot change this anymore.
> 
> That's not true at all.
> 
> Using grep on dmesg is specifically _not_ guaranteed
> to remain stable between kernel versions.

It depends, I guess.  People do use grep after all and people don't
like when things are getting changed underneath; and we don't want
to do this. I think Minchan is with me here. We even didn't add some
additional pr_info/pr_err noise recently because we don't want
people to depend on that part.

http://lkml.iu.edu/hypermail/linux/kernel/1505.3/01759.html

Minchan Kim <minchan@kernel.org>:

|I meant if we remove the pr_err in future by some reason,
|someone might shout
|
|"No, it's ABI so if you guys removes it, it will break user interface's
|semantic". Maybe he seems to depends on parse on dmesg.
|That is not what I want.

And I saw some time ago people doing that type of thing. So I'd like
to avoid unnecessary pain for zram users even if the messages are not
guaranteed to remain stable between kernel releases. Just my opinion.

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] zram: Replace pr_* with dev_* Salah Triki <salah.triki@acm.org> - 2015-08-07 01:00 +0200
  [PATCH 3/3] zram: Replace pr_* with dev_* Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  [PATCH 2/3] zram: Replace pr_info with dev_info in comp_algorithm_store Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  [PATCH 1/3] zram: Replace pr_info with dev_info in max_comp_streams_store Salah Triki <salah.triki@acm.org> - 2015-08-07 01:10 +0200
  Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 02:10 +0200
    Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 03:20 +0200
      Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 03:50 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 03:50 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 04:10 +0200
            Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 04:20 +0200
    Re: [PATCH 0/3] zram: Replace pr_* with dev_* Minchan Kim <minchan@kernel.org> - 2015-08-07 08:10 +0200
      Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 08:40 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 09:00 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Joe Perches <joe@perches.com> - 2015-08-07 09:20 +0200
            Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-07 09:30 +0200
        Re: [PATCH 0/3] zram: Replace pr_* with dev_* Minchan Kim <minchan@kernel.org> - 2015-08-07 17:00 +0200
          Re: [PATCH 0/3] zram: Replace pr_* with dev_* Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2015-08-10 03:30 +0200

csiph-web