Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199326

Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs.

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs.
Date 2015-08-04 01:30 +0200
Message-ID <pTxl7-172-3@gated-at.bofh.it> (permalink)
References <pQVDk-1Py-25@gated-at.bofh.it> <pQWSL-3Ss-35@gated-at.bofh.it> <pSYGK-15R-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Thomas Gleixner <tglx@linutronix.de> writes:

> On Mon, 27 Jul 2015, Eric Anholt wrote:
>> +/* Unmasks the IPI on the CPU wen it's first brought online. */
>
> when
>
>> +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb,
>> +					  unsigned long action, void *hcpu)
>> +{
>> +	unsigned int cpu = (unsigned long)hcpu;
>> +	unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0;
>> +	unsigned int mailbox = 0;
>> +
>> +	if (action == CPU_STARTING || action == CPU_STARTING_FROZEN)
>> +		bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu);
>
> Shouldn't you mask the irq on CPU_DYING?

I was just following what other drivers were doing.  Is CPU_DYING the
only thing that needs masking?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Thomas Gleixner <tglx@linutronix.de> - 2015-08-02 12:30 +0200
  Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Eric Anholt <eric@anholt.net> - 2015-08-04 01:30 +0200
    Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Thomas Gleixner <tglx@linutronix.de> - 2015-08-04 09:20 +0200

csiph-web