Groups > linux.kernel > #1198325

Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs.

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs.
Date	2015-08-02 12:30 +0200
Message-ID	<pSYGK-15R-5@gated-at.bofh.it> (permalink)
References	<pQVDk-1Py-25@gated-at.bofh.it> <pQWSL-3Ss-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 27 Jul 2015, Eric Anholt wrote:
> +/* Unmasks the IPI on the CPU wen it's first brought online. */

when

> +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb,
> +					  unsigned long action, void *hcpu)
> +{
> +	unsigned int cpu = (unsigned long)hcpu;
> +	unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0;
> +	unsigned int mailbox = 0;
> +
> +	if (action == CPU_STARTING || action == CPU_STARTING_FROZEN)
> +		bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu);

Shouldn't you mask the irq on CPU_DYING?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Thomas Gleixner <tglx@linutronix.de> - 2015-08-02 12:30 +0200
  Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Eric Anholt <eric@anholt.net> - 2015-08-04 01:30 +0200
    Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. Thomas Gleixner <tglx@linutronix.de> - 2015-08-04 09:20 +0200

csiph-web