Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1200080
| Path | csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!1.eu.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Ulrich Obergfell <uobergfe@redhat.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() |
| Date | Tue, 04 Aug 2015 17:30:04 +0200 |
| Message-ID | <pTMkc-65J-55@gated-at.bofh.it> (permalink) |
| References | <pSEoF-4YJ-3@gated-at.bofh.it> <pSEoG-4YJ-13@gated-at.bofh.it> <pTKs2-3mh-25@gated-at.bofh.it> |
| X-Original-To | Michal Hocko <mhocko@kernel.org> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| X-Originating-IP | [10.36.5.42] |
| X-Mailer | Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF22 (Linux)/8.0.6_GA_5922) |
| Thread-Topic | watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() |
| Thread-Index | EX2opAQ+gTeiHbP4Urke7SvaF42LkA== |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 27 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, akpm@linux-foundation.org, dzickus@redhat.com, atomlin@redhat.com, jolsa@kernel.org, eranian@google.com, cmetcalf@ezchip.com, fweisbec@gmail.com |
| X-Original-Date | Tue, 4 Aug 2015 11:20:20 -0400 (EDT) |
| X-Original-Message-ID | <390583962.4154938.1438701620927.JavaMail.zimbra@redhat.com> |
| X-Original-References | <1438433365-2979-1-git-send-email-uobergfe@redhat.com> <1438433365-2979-2-git-send-email-uobergfe@redhat.com> <20150804132626.GE28571@dhcp22.suse.cz> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1200080 |
Show key headers only | View raw
> ----- Original Message -----
> From: "Michal Hocko" <mhocko@kernel.org>
...
> On Sat 01-08-15 14:49:22, Ulrich Obergfell wrote:
>> These functions are intended to be used only from inside kernel/watchdog.c
>> to park/unpark all watchdog threads that are specified in watchdog_cpumask.
>
> I would suggest merging this into Patch2. It is usually better to add
> new functions along with their users.
Michal,
watchdog_{park|unpark}_threads are called by watchdog_{suspend|resume}
in Patch 2/4 and by update_watchdog_all_cpus() in Patch 3/4, so I would
have to merge three patches into one, and I would end up with one large
patch and one smaller patch. I think the result would be harder to read,
review and understand. Thus I'd prefer to leave the patches split as they
currently are.
Regards,
Uli
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() Michal Hocko <mhocko@kernel.org> - 2015-08-04 15:30 +0200 Re: [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() Ulrich Obergfell <uobergfe@redhat.com> - 2015-08-04 17:30 +0200
csiph-web