Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199648

Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic

Show all headers | View raw

On Tue, Aug 04, 2015 at 12:33:04PM +0200, Christian Borntraeger wrote:
> Am 04.08.2015 um 11:20 schrieb Peter Zijlstra:
> > On Tue, Aug 04, 2015 at 09:55:48AM +0200, Christian Borntraeger wrote:
> >> kernel build bot showed a warning triggered by commit
> >> 76695af20c01 ("locking, arch: use WRITE_ONCE()/READ_ONCE() in
> >> smp_store_release()/smp_load_acquire()"). Turns out that sparse
> >> does not like WRITE_ONCE accessing elements from the (sparse)
> >> rcu address space.
> >>
> >> fs/afs/inode.c:448:9: sparse: incorrect type in initializer (different address spaces)
> >> fs/afs/inode.c:448:9:    expected struct afs_permits *__val
> >> fs/afs/inode.c:448:9:    got void [noderef] <asn:4>*<noident>
> >>
> >> Solution is to force cast away the sparse attributes for the initializer
> >> of the union in WRITE_SAME. As this now gets too long, lets split
> > 
> > WRITE_ONCE, right?
> 
> Indeed, guess what area I was looking into before....;-)
> 
> Shall I respin or can you fixup.

I've already fixed it. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fixup for WRITE_ONCE vs. sparse Christian Borntraeger <borntraeger@de.ibm.com> - 2015-08-04 10:00 +0200
  [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic Christian Borntraeger <borntraeger@de.ibm.com> - 2015-08-04 10:00 +0200
    Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic Peter Zijlstra <peterz@infradead.org> - 2015-08-04 11:30 +0200
      Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic Christian Borntraeger <borntraeger@de.ibm.com> - 2015-08-04 12:40 +0200
        Re: [PATCH] compiler.h: cast away attributes in WRITE_ONCE magic Peter Zijlstra <peterz@infradead.org> - 2015-08-04 12:50 +0200
    [tip:locking/core] locking, compiler.h:   Cast away attributes in the WRITE_ONCE() magic tip-bot for Christian Borntraeger <tipbot@zytor.com> - 2015-08-12 14:40 +0200

csiph-web