Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199647

[PATCH v2] vmscan: fix increasing nr_isolated incurred by putback unevictable pages

Show all headers | View raw

reclaim_clean_pages_from_list() assumes that shrink_page_list() returns
number of pages removed from the candidate list. But shrink_page_list()
puts back mlocked pages without passing it to caller and without
counting as nr_reclaimed. This incurrs increasing nr_isolated.
To fix this, this patch changes shrink_page_list() to pass unevictable
pages back to caller. Caller will take care those pages.

Signed-off-by: Jaewon Kim <jaewon31.kim@samsung.com>
---
Changes since v1

1/ changed subject from vmscan: reclaim_clean_pages_from_list() must count mlocked pages
2/ changed to return unevictable pages rather than returning the number of unevictable pages

 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5e8eadd..a4b2d07 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1157,7 +1157,7 @@ cull_mlocked:
 		if (PageSwapCache(page))
 			try_to_free_swap(page);
 		unlock_page(page);
-		putback_lru_page(page);
+		list_add(&page->lru, &ret_pages);
 		continue;
 
 activate_locked:
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] vmscan: fix increasing nr_isolated incurred by putback  unevictable pages Jaewon Kim <jaewon31.kim@samsung.com> - 2015-08-04 12:50 +0200
  Re: [PATCH v2] vmscan: fix increasing nr_isolated incurred by  putback unevictable pages Andrew Morton <akpm@linux-foundation.org> - 2015-08-05 00:10 +0200
    Re: [PATCH v2] vmscan: fix increasing nr_isolated incurred by  putback unevictable pages Minchan Kim <minchan@kernel.org> - 2015-08-05 01:40 +0200
      Re: [PATCH v2] vmscan: fix increasing nr_isolated incurred by putback  unevictable pages Jaewon Kim <jaewon31.kim@samsung.com> - 2015-08-05 03:00 +0200
        Re: [PATCH v2] vmscan: fix increasing nr_isolated incurred by putback  unevictable pages Vlastimil Babka <vbabka@suse.cz> - 2015-08-06 14:30 +0200

csiph-web