Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1198436

[PATCH v2] Revert "Staging : lustre: Struct file_operations should be const"

Show all headers | View raw

Declare the file_operations structure ll_file_operations as const, as done
elsewhere in the kernel, as there are no modifications to its fields.

Problem found using checkpatch.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
Changes in v2:
  - Make the commit message more clearer.

 drivers/staging/lustre/lustre/llite/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
index 369a722..dcd0c6d 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -3116,7 +3116,7 @@ int ll_inode_permission(struct inode *inode, int mask)
 }
 
 /* -o localflock - only provides locally consistent flock locks */
-const struct file_operations ll_file_operations = {
+struct file_operations ll_file_operations = {
 	.read_iter = ll_file_read_iter,
 	.write_iter = ll_file_write_iter,
 	.unlocked_ioctl = ll_file_ioctl,
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging : lustre: Struct file_operations should be const Shraddha Barke <shraddha.6596@gmail.com> - 2015-08-02 13:10 +0200
  Re: [PATCH] Staging : lustre: Struct file_operations should be  const Julia Lawall <julia.lawall@lip6.fr> - 2015-08-02 13:30 +0200
  [PATCH v2] Revert "Staging : lustre: Struct file_operations should be const" Shraddha Barke <shraddha.6596@gmail.com> - 2015-08-02 19:40 +0200
    Re: [PATCH v2] Revert "Staging : lustre: Struct file_operations  should be const" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-03 07:30 +0200

csiph-web