Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1198337

Re: [PATCH] Staging : lustre: Struct file_operations should be const

Show all headers | View raw

On Sun, 2 Aug 2015, Shraddha Barke wrote:

> This patch fixes the following checkpatch.pl warning:
> 
> WARNING: struct file_operations should normally be const

This is not the good way to write the message.  The information it conveys 
is "checkpatch generated this warning, so I have made some change 
(unspecified) that make checkpatch not complain".

A better approach would be to say:

Declare the file_operations structure ll_file_operations as const, as done 
elsewhere in the kernel, as there are no modifications to its fields.

Problem found using checkpatch.

This way the reader knows what was done, and what issues were taken into 
account when making the change.  At the same time, you still credit 
checkpatch for helping you find the problem

julia

> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/staging/lustre/lustre/llite/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index dcd0c6d..369a722 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -3116,7 +3116,7 @@ int ll_inode_permission(struct inode *inode, int mask)
>  }
>  
>  /* -o localflock - only provides locally consistent flock locks */
> -struct file_operations ll_file_operations = {
> +const struct file_operations ll_file_operations = {
>  	.read_iter = ll_file_read_iter,
>  	.write_iter = ll_file_write_iter,
>  	.unlocked_ioctl = ll_file_ioctl,
> -- 
> 2.1.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging : lustre: Struct file_operations should be const Shraddha Barke <shraddha.6596@gmail.com> - 2015-08-02 13:10 +0200
  Re: [PATCH] Staging : lustre: Struct file_operations should be  const Julia Lawall <julia.lawall@lip6.fr> - 2015-08-02 13:30 +0200
  [PATCH v2] Revert "Staging : lustre: Struct file_operations should be const" Shraddha Barke <shraddha.6596@gmail.com> - 2015-08-02 19:40 +0200
    Re: [PATCH v2] Revert "Staging : lustre: Struct file_operations  should be const" Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-03 07:30 +0200

csiph-web