Groups > linux.kernel > #1198382

Re: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock event is unused

Path	csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock event is unused
Date	Sun, 02 Aug 2015 11:20:03 +0200
Message-ID	<pSXB0-80B-7@gated-at.bofh.it> (permalink)
References	<pNjEd-6vh-11@gated-at.bofh.it> <pNjEd-6vh-9@gated-at.bofh.it> <pNvvI-6Vg-3@gated-at.bofh.it> <pNIMh-Ah-7@gated-at.bofh.it> <pOffc-59c-15@gated-at.bofh.it> <pOp4S-2gs-25@gated-at.bofh.it> <pOqaB-3Q4-17@gated-at.bofh.it>
X-Original-To	Alexandre Belloni <alexandre.belloni@free-electrons.com>
User-Agent	Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score	-1.0
X-Linutronix-Spam-Level	-
X-Linutronix-Spam-Status	No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Daniel Lezcano <daniel.lezcano@linaro.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, LAK <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, David Dueck <davidcdueck@googlemail.com>, Sebastian Sewior <bigeasy@linutronix.de>
X-Original-Date	Sun, 2 Aug 2015 11:10:21 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.11.1508021100390.3825@nanos>
X-Original-References	<1437161608-26782-1-git-send-email-alexandre.belloni@free-electrons.com> <1437161608-26782-2-git-send-email-alexandre.belloni@free-electrons.com> <alpine.DEB.2.11.1507180942360.18576@nanos> <20150718222308.GA30489@piout.net> <alpine.DEB.2.11.1507201103550.18576@nanos> <20150720193726.GJ15539@piout.net> <alpine.DEB.2.11.1507202245310.18576@nanos>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1198382

Show key headers only | View raw

On Mon, 20 Jul 2015, Thomas Gleixner wrote:

> On Mon, 20 Jul 2015, Alexandre Belloni wrote:
> 
> > On 20/07/2015 at 11:04:30 +0200, Thomas Gleixner wrote :
> > > That's why I used setup/remove_irq() in the stale RT changes.
> > > 
> > 
> > Hum, actually, you hit the same thing with setup/remove_irq (and I'm not sure
> > to follow why):
> 
> It's the kmalloc of the proc interface. So back to the drawing
> board. I'll think about it tomorrow with brain awake.

So the only idea I could come up with is the old approach of creating
a dummy irq chip for the interrupts which share that timer/uart/rtc
whatever line.

I think Boris Brezillon had implemented it at some point, but it was
shot down for reasons I can't remember. That would allow us to simply
have disable_irq_nosync/enable_irq in the relevant code pathes and be
done with it. I guess I need to find the references and give it a try
again if nobody beats me to it.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] clocksource: atmel-st: Remove irq handler when clock  event is unused Thomas Gleixner <tglx@linutronix.de> - 2015-08-02 11:20 +0200

csiph-web