Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1194780

Re: [PATCH] arch/*/io.h: Add ioremap_uc() to all architectures

From Stephen Rothwell <sfr@canb.auug.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH] arch/*/io.h: Add ioremap_uc() to all architectures
Date 2015-07-29 05:10 +0200
Message-ID <pRpUJ-41i-5@gated-at.bofh.it> (permalink)
References <pRhNw-rv-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Luis,

On Tue, 28 Jul 2015 11:22:07 -0700 "Luis R. Rodriguez" <mcgrof@do-not-panic.com> wrote:
>
> From: "Luis R. Rodriguez" <mcgrof@suse.com>
> 
> This adds ioremap_uc() only for architectures that do not
> include asm-generic.h/io.h as that already provides a default
> definition for them for both cases where you have CONFIG_MMU
> and you do not, and because of this, the number of architectures
> this patch address is less than the architectures that the
> ioremap_wt() patch addressed, "arch/*/io.h: Add ioremap_wt() to all
> architectures").
> 
> In order to reduce the number of architectures we have to
> modify when adding new architecture IO APIs we'll have to review
> the architectures in this patch, see why they can't add
> asm-generic.h/io.h or issues that would be created by doing
> so and then spread a consistent inclusion of this header
> towards the end of their own header. For instance arch/metag
> includes the asm-generic/io.h *before* the ioremap*()
> definitions, this should be the other way around but only
> once we have guard wrappers for the non-MMU case also for
> asm-generic/io.h.
> 
> Cc: Arnd Bergmann <arnd@arndb.de>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
> ---
>  arch/avr32/include/asm/io.h   | 1 +
>  arch/frv/include/asm/io.h     | 1 +
>  arch/m32r/include/asm/io.h    | 1 +
>  arch/m68k/include/asm/io_mm.h | 1 +
>  arch/mn10300/include/asm/io.h | 1 +
>  arch/powerpc/include/asm/io.h | 1 +
>  arch/sh/include/asm/io.h      | 1 +
>  arch/tile/include/asm/io.h    | 1 +
>  8 files changed, 8 insertions(+)

I have added this to linux-next today instead of reverting the other 2
patches.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] arch/*/io.h: Add ioremap_uc() to all architectures Stephen Rothwell <sfr@canb.auug.org.au> - 2015-07-29 05:10 +0200

csiph-web