Groups > linux.kernel > #1194655

Re: [PATCH] virtio_mmio: add ACPI probing

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	G Gregory <graeme.gregory@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] virtio_mmio: add ACPI probing
Date	Tue, 28 Jul 2015 22:30:01 +0200
Message-ID	<pRjFD-39y-5@gated-at.bofh.it> (permalink)
References	<pR9Gj-5oW-7@gated-at.bofh.it> <pR9ZD-61X-9@gated-at.bofh.it> <pRa9m-6eh-67@gated-at.bofh.it> <pRaiZ-6q0-1@gated-at.bofh.it> <pRjvY-2Ym-29@gated-at.bofh.it>
X-Original-To	Peter Maydell <peter.maydell@linaro.org>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=K5ll3fKvXjod975+vRycBisDWLwNAz7aUgiYCHmWtqM=; b=ScmDojSjsyA4WU6dQ+vb21LQEDof+yWg2drk8ESd6Jfc26d3PFraB4dfZ3XkjEcoQS W/aqd3y5Or7hYbA4r6no6cLGlakBRvSrTS+sprmVeGCJ4SBXSqhAYeWThkfdAU3ot27b HHrdTSA+V2YqX1VtdyiL/7i5eA000kirlwKvDzKQnFpIOKZQsQOvhe7pgC3kMYlYuKKz msYpAwCTjJaZAIk55FcMeJhshCJCveltiieiNo80KQFeCzcqoIyAmwcfGs8ib4GvDRlP BLIvGxUzv3P35+PTZuESBaHIq+DKJGOYDvpaNWt2msQBp/xYy6+ETxCkdfeadAu14woW Pnag==
X-Gm-Message-State	ALoCoQmwc+JO1yRfUOkYp1yWiDlPCfyvkOAmqYxogR5VaL/zzRnxMaubDwvuOR37VAF/gFljgCop
MIME-Version	1.0
X-Received	by 10.152.22.4 with SMTP id z4mr35150933lae.81.1438115326489; Tue, 28 Jul 2015 13:28:46 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	"Michael S. Tsirkin" <mst@redhat.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>, Shannon Zhao <shannon.zhao@linaro.org>, Alex Bennée <alex.bennee@linaro.org>
X-Original-Date	Tue, 28 Jul 2015 21:28:46 +0100
X-Original-Message-ID	<CAGCh1+kRyGNOH9mxRuEBLN+Ap4eJGS0wCC3YroBDuGnh8FsNKw@mail.gmail.com>
X-Original-References	<1438076642-12080-1-git-send-email-graeme.gregory@linaro.org> <20150728130604-mutt-send-email-mst@redhat.com> <CAFEAcA9H6_oEFKFFNhcGW-8Yy8ng9iNnPbweTvMC46fwLmwA0w@mail.gmail.com> <20150728132113-mutt-send-email-mst@redhat.com> <CAFEAcA9x5kcojVAm-n4ycXQTK3yePqqv9DKvtREfpe5newAZvg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1194655

Show key headers only | View raw

On 28 July 2015 at 21:12, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 28 July 2015 at 11:27, Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Tue, Jul 28, 2015 at 11:12:33AM +0100, Peter Maydell wrote:
>>> On 28 July 2015 at 11:08, Michael S. Tsirkin <mst@redhat.com> wrote:
>>> > On Tue, Jul 28, 2015 at 10:44:02AM +0100, Graeme Gregory wrote:
>>> >> Added the match table and pointers for ACPI probing to the driver.
>>> >>
>>> >> This uses the same identifier for virt devices as being used for qemu
>>> >> ARM64 ACPI support.
>>> >>
>>> >> http://git.linaro.org/people/shannon.zhao/qemu.git/commit/d0bf1955a3ecbab4b51d46f8c5dda02b7e14a17e
>>> >>
>>> >> Signed-off-by: Graeme Gregory <graeme.gregory@linaro.org>
>
>>> >> +#ifdef CONFIG_ACPI
>>> >> +static const struct acpi_device_id virtio_mmio_acpi_match[] = {
>>> >> +     { "LNRO0005", },
>>> >> +     { }
>>> >> +};
>>> >
>>> > Hmm - we have reserved QEMUXXXX in ASWG explicitly for this purpose.
>>> >
>>> > Pater - do you think it's a good idea to change this before QEMU 2.4
>>> > is released?
>>>
>>> Shannon's call, I guess. I don't know enough about ACPI to say.
>>> I thought these ACPI IDs were already fixed because they were
>>> what the kernel was looking for...
>
>> Apparently not :)
>
> Mmm. I'm not terribly happy about stuff being in QEMU before the
> ACPI spec for it has been finalised. We should not be picking
> stuff randomly on the fly...
>
> If we want to fix the ACPI IDs QEMU is using for 2.4 then we
> really need to do that now (ie within the next day or two).
>
It is upto the owner of the QEMU prefix to allocate numbers. This is
not an issue for ACPI spec at all.

Graeme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] virtio_mmio: add ACPI probing Graeme Gregory <graeme.gregory@linaro.org> - 2015-07-28 11:50 +0200
  Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-28 12:10 +0200
    Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 12:20 +0200
      Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-28 12:30 +0200
        Re: [PATCH] virtio_mmio: add ACPI probing G Gregory <graeme.gregory@linaro.org> - 2015-07-28 12:40 +0200
        Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 22:20 +0200
          Re: [PATCH] virtio_mmio: add ACPI probing G Gregory <graeme.gregory@linaro.org> - 2015-07-28 22:30 +0200
            Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 23:20 +0200
              Re: [PATCH] virtio_mmio: add ACPI probing Shannon Zhao <shannon.zhao@linaro.org> - 2015-07-29 04:10 +0200
                Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-29 12:10 +0200

csiph-web