Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1193993

Re: [PATCH] virtio_mmio: add ACPI probing

From "Michael S. Tsirkin" <mst@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] virtio_mmio: add ACPI probing
Date 2015-07-28 12:10 +0200
Message-ID <pR9ZD-61X-9@gated-at.bofh.it> (permalink)
References <pR9Gj-5oW-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 28, 2015 at 10:44:02AM +0100, Graeme Gregory wrote:
> Added the match table and pointers for ACPI probing to the driver.
> 
> This uses the same identifier for virt devices as being used for qemu
> ARM64 ACPI support.
> 
> http://git.linaro.org/people/shannon.zhao/qemu.git/commit/d0bf1955a3ecbab4b51d46f8c5dda02b7e14a17e
> 
> Signed-off-by: Graeme Gregory <graeme.gregory@linaro.org>
> ---
>  drivers/virtio/virtio_mmio.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 10189b5..f499d9d 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -58,6 +58,7 @@
>  
>  #define pr_fmt(fmt) "virtio-mmio: " fmt
>  
> +#include <linux/acpi.h>
>  #include <linux/highmem.h>
>  #include <linux/interrupt.h>
>  #include <linux/io.h>
> @@ -732,12 +733,21 @@ static struct of_device_id virtio_mmio_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, virtio_mmio_match);
>  
> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id virtio_mmio_acpi_match[] = {
> +	{ "LNRO0005", },
> +	{ }
> +};

Hmm - we have reserved QEMUXXXX in ASWG explicitly for this purpose.

Pater - do you think it's a good idea to change this before QEMU 2.4
is released?

> +MODULE_DEVICE_TABLE(acpi, virtio_mmio_acpi_match);
> +#endif
> +
>  static struct platform_driver virtio_mmio_driver = {
>  	.probe		= virtio_mmio_probe,
>  	.remove		= virtio_mmio_remove,
>  	.driver		= {
>  		.name	= "virtio-mmio",
>  		.of_match_table	= virtio_mmio_match,
> +		.acpi_match_table = ACPI_PTR(virtio_mmio_acpi_match),
>  	},
>  };
>  
> -- 
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] virtio_mmio: add ACPI probing Graeme Gregory <graeme.gregory@linaro.org> - 2015-07-28 11:50 +0200
  Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-28 12:10 +0200
    Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 12:20 +0200
      Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-28 12:30 +0200
        Re: [PATCH] virtio_mmio: add ACPI probing G Gregory <graeme.gregory@linaro.org> - 2015-07-28 12:40 +0200
        Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 22:20 +0200
          Re: [PATCH] virtio_mmio: add ACPI probing G Gregory <graeme.gregory@linaro.org> - 2015-07-28 22:30 +0200
            Re: [PATCH] virtio_mmio: add ACPI probing Peter Maydell <peter.maydell@linaro.org> - 2015-07-28 23:20 +0200
              Re: [PATCH] virtio_mmio: add ACPI probing Shannon Zhao <shannon.zhao@linaro.org> - 2015-07-29 04:10 +0200
                Re: [PATCH] virtio_mmio: add ACPI probing "Michael S. Tsirkin" <mst@redhat.com> - 2015-07-29 12:10 +0200

csiph-web