Groups > linux.kernel > #1195909

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data
Date	2015-07-30 13:00 +0200
Message-ID	<pRTJ8-4ud-13@gated-at.bofh.it> (permalink)
References	(3 earlier) <pRCoW-4WU-17@gated-at.bofh.it> <pRDbj-66K-15@gated-at.bofh.it> <pREh3-7GV-3@gated-at.bofh.it> <pREAq-83y-11@gated-at.bofh.it> <pRRnY-1g4-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jul 30, 2015 at 10:24:37AM +0200, Michal Suchanek wrote:

> So my suggestion is to

> 1) search of ofpart subnode in mtd node. If present read address and
> reg from it and search partitions as subnodes of the ofpart node. In
> this case unknown nodes can cause error.

> 2) failing that issue a warning and try to parse ofpart partitions
> from the mtd node itself. In this case unknown nodes cannot cause
> error for compatibility with other drivers including the already
> exisitn s3c64xx controller-data node.

> The parser code can be the same for both cases and only operate on
> different node with a flag to reject unknown subnodes or not.

That seems reasonable to me.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to  controller-data Mark Brown <broonie@kernel.org> - 2015-07-29 16:10 +0200
  Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data Michal Suchanek <hramrach@gmail.com> - 2015-07-30 10:30 +0200
    Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to  controller-data Mark Brown <broonie@kernel.org> - 2015-07-30 13:00 +0200

csiph-web