Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195228

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 29, 2015 at 12:19:57PM +0200, Michal Suchanek wrote:

Please use subject lines matching the style for the subsytsem so people
can spot that the patch is in some way relevant.

> The controller-data subnode has no compatible. This can lead to other
> drivers getting confused by it. Add a compatible to make devicetreee
> unambiguous.

I can't tell from this commit message what the issue you're trying to
fix is, sorry.  Nodes without compatible strings are entirely normal and
don't need compatible strings.  It sounds like a bug in whatever other
driver is becoming confused.

> +	if (!of_get_property(data_np, "compatible", NULL) ||
> +	    strcmp(of_get_property(data_np, "compatible", NULL),
> +		   "samsung,s3c-controller-data"))
> +		dev_err(&spi->dev, "child node 'controller-data' does not have correct compatible\n");

This will break all existing users which is not acceptable for
mainline, we need to preserve compatibility with existing device trees.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to  controller-data Mark Brown <broonie@kernel.org> - 2015-07-29 16:10 +0200
  Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data Michal Suchanek <hramrach@gmail.com> - 2015-07-30 10:30 +0200
    Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to  controller-data Mark Brown <broonie@kernel.org> - 2015-07-30 13:00 +0200

csiph-web