Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1193074
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API |
| Date | 2015-07-27 15:20 +0200 |
| Message-ID | <pQQtX-2W3-1@gated-at.bofh.it> (permalink) |
| References | <pOMuu-2gx-15@gated-at.bofh.it> <pPxa2-3nQ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 24, 2015 at 12:23 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote:
>> Commit b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>> makes the flags argument to devm_gpiod_get_optional mandatory but does not
>> update all users. This results in the following build error.
>>
>> drivers/tty/serial/etraxfs-uart.c:933:16: error:
>> too few arguments to function ‘devm_gpiod_get_optional’
>>
>> Fixes: b17d1bf16cc7 ("gpio: make flags mandatory for gpiod_get functions")
>
> This patch isn't in Linus's tree, so whatever tree this commit is in,
> needs to also take this fix.
OK I'll take it. It's a bit messy with this breakage but it is for
a good cause.
Niklas: send me your patch when finished.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-07-24 00:30 +0200
Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Linus Walleij <linus.walleij@linaro.org> - 2015-07-27 15:20 +0200
Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Niklas Cassel <niklas.cassel@axis.com> - 2015-07-27 15:30 +0200
Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2015-07-27 16:00 +0200
Re: [PATCH -next] serial: etraxfs-uart: Update gpiod API Linus Walleij <linus.walleij@linaro.org> - 2015-07-27 16:10 +0200
csiph-web