Groups > linux.kernel > #1192963

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface
Date	2015-07-27 13:00 +0200
Message-ID	<pQOiu-7Lc-7@gated-at.bofh.it> (permalink)
References	<pPPzX-4Yj-5@gated-at.bofh.it> <pPPzY-4Yj-21@gated-at.bofh.it> <pQNmp-6qa-3@gated-at.bofh.it> <pQNPt-7dH-23@gated-at.bofh.it> <pQO8O-7zV-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jul 27, 2015 at 12:47:55PM +0200, Peter Zijlstra wrote:
> On Mon, Jul 27, 2015 at 12:20:46PM +0200, Heiko Carstens wrote:
> > On Mon, Jul 27, 2015 at 11:52:25AM +0200, Peter Zijlstra wrote:
> > > > +static __always_inline bool arch_static_branch_jump(struct static_key *key, bool branch)
> > > > +{
> > > > +	asm_volatile_goto("0:	j %l[l_yes]\n"
> > > 
> > > Looking at the s390 version of jump_label_make_branch(), this should
> > > have been:
> > > 
> > > 		"brcl 15, %l[l_yes]\n"
> > > 
> > > I suppose?
> > 
> > Yes. I wanted to test your version, but I assume you will send
> > an updated version soon?
> 
> I just send out updated patches for 5/6. They boot without issue on my
> x86_64.

Also, it helps if you convert one static_key user into something that'll
trigger this new code.

The one I picked is unfortunately rather x86 specific.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra <peterz@infradead.org> - 2015-07-27 12:00 +0200
  Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-07-27 12:30 +0200
    Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra <peterz@infradead.org> - 2015-07-27 12:50 +0200
      Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Heiko Carstens <heiko.carstens@de.ibm.com> - 2015-07-27 13:00 +0200
        Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra <peterz@infradead.org> - 2015-07-27 16:40 +0200
      Re: [RFC][PATCH 6/7] jump_label: Add a new static_key interface Peter Zijlstra <peterz@infradead.org> - 2015-07-27 13:00 +0200

csiph-web