Groups > linux.kernel > #1192579

Re: [PATCH 1/8] misc: cxl: clean up afu_read_config()

From	Daniel Axtens <dja@axtens.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] misc: cxl: clean up afu_read_config()
Date	2015-07-27 01:10 +0200
Message-ID	<pQDdo-rc-5@gated-at.bofh.it> (permalink)
References	<pQBEB-6zs-3@gated-at.bofh.it> <pQBEB-6zs-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Reviewed-by: Daniel Axtens <dja@axtens.net>

FWIW, Ian is on leave for 2 weeks and Mikey for 1 week. However, as one
of the other CXL developers I'm very happy for this patch to go in.

Regards,
Daniel

On Mon, 2015-07-27 at 00:18 +0300, Vladimir Zapolskiy wrote:
> The sanity checks for overflow are not needed, because this is done on
> caller side in fs/sysfs/file.c
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Ian Munsie <imunsie@au1.ibm.com>
> Cc: Michael Neuling <mikey@neuling.org>
> ---
>  drivers/misc/cxl/sysfs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
> index 31f38bc..87cd747 100644
> --- a/drivers/misc/cxl/sysfs.c
> +++ b/drivers/misc/cxl/sysfs.c
> @@ -443,12 +443,7 @@ static ssize_t afu_read_config(struct file *filp, struct kobject *kobj,
>  	struct afu_config_record *cr = to_cr(kobj);
>  	struct cxl_afu *afu = to_cxl_afu(container_of(kobj->parent, struct device, kobj));
>  
> -	u64 i, j, val, size = afu->crs_len;
> -
> -	if (off > size)
> -		return 0;
> -	if (off + count > size)
> -		count = size - off;
> +	u64 i, j, val;
>  
>  	for (i = 0; i < count;) {
>  		val = cxl_afu_cr_read64(afu, cr->cr, off & ~0x7);

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/8] misc: cxl: clean up afu_read_config() Daniel Axtens <dja@axtens.net> - 2015-07-27 01:10 +0200

csiph-web