Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Daniel Axtens <dja@axtens.net>
Newsgroups: linux.kernel
Subject: Re: [PATCH 1/8] misc: cxl: clean up afu_read_config()
Date: Mon, 27 Jul 2015 01:10:02 +0200
Message-ID: <pQDdo-rc-5@gated-at.bofh.it>
References: <pQBEB-6zs-3@gated-at.bofh.it> <pQBEB-6zs-5@gated-at.bofh.it>
Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-D9zqCHhwTF4rxmkG8/GG"
MIME-Version: 1.0
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 80
Organization: linux.* mail to news gateway
Xref: aioe.org linux.kernel:1192579


--=-D9zqCHhwTF4rxmkG8/GG
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Reviewed-by: Daniel Axtens <dja@axtens.net>

FWIW, Ian is on leave for 2 weeks and Mikey for 1 week. However, as one
of the other CXL developers I'm very happy for this patch to go in.

Regards,
Daniel

On Mon, 2015-07-27 at 00:18 +0300, Vladimir Zapolskiy wrote:
> The sanity checks for overflow are not needed, because this is done on
> caller side in fs/sysfs/file.c
>=20
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Ian Munsie <imunsie@au1.ibm.com>
> Cc: Michael Neuling <mikey@neuling.org>
> ---
>  drivers/misc/cxl/sysfs.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/drivers/misc/cxl/sysfs.c b/drivers/misc/cxl/sysfs.c
> index 31f38bc..87cd747 100644
> --- a/drivers/misc/cxl/sysfs.c
> +++ b/drivers/misc/cxl/sysfs.c
> @@ -443,12 +443,7 @@ static ssize_t afu_read_config(struct file *filp, st=
ruct kobject *kobj,
>  	struct afu_config_record *cr =3D to_cr(kobj);
>  	struct cxl_afu *afu =3D to_cxl_afu(container_of(kobj->parent, struct de=
vice, kobj));
> =20
> -	u64 i, j, val, size =3D afu->crs_len;
> -
> -	if (off > size)
> -		return 0;
> -	if (off + count > size)
> -		count =3D size - off;
> +	u64 i, j, val;
> =20
>  	for (i =3D 0; i < count;) {
>  		val =3D cxl_afu_cr_read64(afu, cr->cr, off & ~0x7);


--=-D9zqCHhwTF4rxmkG8/GG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: GPGTools - https://gpgtools.org

iQIcBAABCgAGBQJVtWfnAAoJEPC3R3P2I92FTVoP/RUopov9Rq2zPs14JIsMrGbv
GDGNAWxCoKeHopeMTttENPItWAIeUx26NWaqY1T/XSbUcx91h0WCz1Ww/7yoQz5K
WYqMgguSawrGR0Sy43yAc6gQM1C+D8n2ow+7i+b5D1bQp7FZGAHkaNdLNXuHHNlU
QT2zymKINVfulXrxI6d+du/1QWjDkvum23N8rxRS9fGDfAztqoI3bacpuD7V9G+F
YPtoryi94HDwFXTPqbRxElCsDnVaQYjzIzlcdO+24n3UGpwzaIrJEQ8RH/fA3tDX
WrSioaVpGs3zBz1XBXRP8CAFdKfSuduVSjVhahL530QXWmcQQLwHap9JD8o8w9xX
EcdM5FeMhTBcBMDmt5gGsh/J0E9FieDGtHgh8ZaRqIVHs4AEiR40SDXg9/5eizdn
b62FAqjj9bRFti6sFaz+O1i11IJzcDhGaFWsIpQFavkLtT9hGvogSdqTJUHuTKTc
ezwxjI992CCQ85i5OC4rDvEqI8NwfNgmUo3Xy6KwQRVUEwBlYxxC8I1XRDu/JyIA
m+jUyV6DEU3QZ9WVL99Qq4dN/u4qA+PZt3nA6RbR98XW7A1ktt03I+LbsHYCdftU
XIILkSyIi5bCnvjwYmEjIdei8gPYU/eN4yPj5rgoxxLyXUomQQ6uNDY5YlB6f4uZ
zweaO8gS3OJyXisiybtG
=UOzo
-----END PGP SIGNATURE-----

--=-D9zqCHhwTF4rxmkG8/GG--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/