Groups > linux.kernel > #1191137

Re: [PATCH 0/8] Add support for additional bq27xxx devices

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Andreas Dannenberg <dannenberg@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] Add support for additional bq27xxx devices
Date	Thu, 23 Jul 2015 19:10:03 +0200
Message-ID	<pPsan-4z3-45@gated-at.bofh.it> (permalink)
References	<pPan8-46e-11@gated-at.bofh.it> <pPrxF-3z2-35@gated-at.bofh.it>
X-Original-To	Pali Rohár <pali.rohar@gmail.com>, "Andrew F. Davis" <afd@ti.com>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	Sebastian Reichel <sre@kernel.org>, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Dan Murphy <dmurphy@ti.com>, <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 23 Jul 2015 12:01:22 -0500
X-Original-Message-ID	<55B11DE2.3030502@ti.com>
X-Original-References	<1437601920-13045-1-git-send-email-afd@ti.com> <20150723162748.GJ29125@pali>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1191137

Show key headers only | View raw

On 07/23/2015 11:27 AM, Pali Rohár wrote:
> On Wednesday 22 July 2015 16:51:52 Andrew F. Davis wrote:

<snip>

> And I have another question for you: I see that there are now more
> bq24*_charger.c drivers for TI BQ charger chips. Do you think if it is
> possible to do some cleanup & merge? Or all those charger chips
> different and every one should live in own kernel module?

Pali,
on a related note I recently started working on a new driver named
bq242xx_charger.c that will add support for the following devices:

bq24250
bq24251
bq24261M
bq24262

These are TI's key devices in the bq2425x and bq2426x sub-families. I was
actually also thinking about some larger consolidation but was
concerned about touching/breaking existing stuff and decided to do one
step at a time. And yes while there is some system-level overlap between
most bq24xxx I'm also worried that providing good coverage of all
important device features for all different bq24xxx devices would yield
a very large and hard to understand driver.

As part of the bq242xx_charger.c development I'm keeping a close eye on
the existing bq24xxx drivers. If there seems an elegant way to do some
consolidation after all I might be able to broaden the scope of my work.

This being said I welcome additional ideas/suggestions here but for this
we should probably start a new thread.

Regards,

-- 
Andreas Dannenberg
Texas Instruments Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 0/8] Add support for additional bq27xxx devices Andreas Dannenberg <dannenberg@ti.com> - 2015-07-23 19:10 +0200

csiph-web