Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1190042

Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain field

Show all headers | View raw

On 22/07/15 15:48, Bjorn Helgaas wrote:
> On Wed, Jul 22, 2015 at 9:42 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> Hi Bjorn,
>>
>> On 21/07/15 22:26, Bjorn Helgaas wrote:
>>> On Wed, Jul 15, 2015 at 01:16:38PM +0100, Marc Zyngier wrote:
>>>> In order to be able to populate the device msi_domain field,
>>>> add the necesary hooks to propagate the host bridge msi_domain
>>>> across secondary busses to devices.
>>>>
>>>> So far, nobody populates the initial msi_domain.
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>> ---
>>>>  drivers/pci/probe.c | 30 ++++++++++++++++++++++++++++++
>>>>  include/linux/pci.h |  1 +
>>>>  2 files changed, 31 insertions(+)
>>>>
>>>> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
>>>> index cefd636..376f6fa 100644
>>>> --- a/drivers/pci/probe.c
>>>> +++ b/drivers/pci/probe.c
>>>> @@ -661,6 +661,20 @@ static void pci_set_bus_speed(struct pci_bus *bus)
>>>>      }
>>>>  }
>>>>
>>>> +void __weak pcibios_set_host_bridge_msi_domain(struct pci_bus *bus)
>>>> +{
>>>> +}
>>>
>>> I don't think there's anything in this series that requires this to be a
>>> weak function, is there?  This is the only definition I see.
>>
>> It looks like all the pcibios_* functions so far have a weak attribute,
>> and I've added it as a matter of consistency.
> 
> We've used pcibios_* names where we might need an arch-specific
> implementation.  I'm not sure that's the case here -- do you envision
> an implementation under arch/* someday?  If not, maybe it should just
> be a pci_* function instead of pcibios_*.

I could definitely see non-OF driven architectures wanting to override this.

Or maybe we should turn it the other way around and make it call the
various firmware interfaces (OF, ACPI...) until one of them succeeds. In
which case your suggestion of making it a pci_* function makes a lot of
sense.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/19] Per-device MSI domain & platform MSI Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 02/19] PCI: MSI: Register irq domain with specific token Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 11/19] irqchip: gicv3-its: Split PCI/MSI code from the core ITS driver Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 08/19] platform: of: Assign MSI domain to platform device Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 19/19] PCI/MSI: Drop domain field from msi_controller Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 05/19] PCI/MSI: of: Add support for OF-provided msi_domain Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 07/19] PCI/MSI: Let pci_msi_get_domain use struct device's msi_domain Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
    Re: [PATCH v4 07/19] PCI/MSI: Let pci_msi_get_domain use struct device's  msi_domain Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 17:30 +0200
  [PATCH v4 03/19] device core: Introduce per-device MSI domain pointer Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 14/19] irqchip: gicv3-its: Make the PCI/MSI code standalone Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 16/19] irqchip: GICv2m: Get rid of struct msi_controller Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 12/19] irqchip: gicv3-its: Register irq domain with NEXUS token Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 13/19] irqchip: gicv3-its: Get rid of struct msi_controller Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 17/19] irqchip: GICv2m: Add platform MSI support Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:20 +0200
  [PATCH v4 10/19] genirq: Add DOMAIN_BUS_NEXUS irqdomain property Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:30 +0200
  [PATCH v4 01/19] genirq: irqdomain: Allow irq domain aliasing Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:30 +0200
  [PATCH v4 06/19] PCI/MSI: of: Allow msi_domain lookup using the host bridge node Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:30 +0200
  [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-15 14:30 +0200
    Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain  field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 16:50 +0200
      Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain field Bjorn Helgaas <bhelgaas@google.com> - 2015-07-22 16:50 +0200
        Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain  field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 17:00 +0200
          Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain  field Bjorn Helgaas <bhelgaas@google.com> - 2015-07-22 19:00 +0200
            Re: [PATCH v4 04/19] PCI/MSI: Add hooks to populate the msi_domain  field Marc Zyngier <marc.zyngier@arm.com> - 2015-07-22 19:50 +0200

csiph-web