Re: [PATCH v2] cgroup: net_cls: fix false-positive "suspicious RCU usage"

From	Daniel Borkmann <daniel@iogearbox.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] cgroup: net_cls: fix false-positive "suspicious RCU usage"
Date	2015-07-22 14:10 +0200
Message-ID	<pP10t-6mP-1@gated-at.bofh.it> (permalink)
References	<pOITU-5xi-11@gated-at.bofh.it> <pOYvE-2HX-19@gated-at.bofh.it> <pP0QN-5Wa-3@gated-at.bofh.it> <pP10t-6mP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/22/2015 02:03 PM, Konstantin Khlebnikov wrote:
> On 22.07.2015 14:56, Daniel Borkmann wrote:
>> On 07/22/2015 11:23 AM, Konstantin Khlebnikov wrote:
>>> In dev_queue_xmit() net_cls protected with rcu-bh.
>> ...
>>> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
>>> ---
>>>   net/core/netclassid_cgroup.c |    3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c
>>> index 1f2a126f4ffa..6441f47b1a8f 100644
>>> --- a/net/core/netclassid_cgroup.c
>>> +++ b/net/core/netclassid_cgroup.c
>>> @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state
>>> *css_cls_state(struct cgroup_subsys_state
>>>
>>>   struct cgroup_cls_state *task_cls_state(struct task_struct *p)
>>>   {
>>> -    return css_cls_state(task_css(p, net_cls_cgrp_id));
>>> +    return css_cls_state(task_css_check(p, net_cls_cgrp_id,
>>> +                        rcu_read_lock_bh_held()));
>>
>> Did you also check that after your patch this doesn't trigger on ingress
>> either? There, this code path could be invoked under rcu_read_lock(). So,
>> perhaps you need to check for both.
>
> I haven't seen warnings with this patch. rcu_read_lock_held() is
> checked inside rcu_dereference_check() inside task_css_check().

Thanks, agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v2] cgroup: net_cls: fix false-positive "suspicious RCU  usage" Daniel Borkmann <daniel@iogearbox.net> - 2015-07-22 14:00 +0200
  Re: [PATCH v2] cgroup: net_cls: fix false-positive "suspicious RCU  usage" Daniel Borkmann <daniel@iogearbox.net> - 2015-07-22 14:10 +0200
  Re: [PATCH v2] cgroup: net_cls: fix false-positive "suspicious RCU  usage" Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2015-07-22 14:10 +0200

csiph-web