Re: [Intel-gfx] [PATCH] drm/i915: add error path

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [Intel-gfx] [PATCH] drm/i915: add error path
Date	2015-07-22 14:00 +0200
Message-ID	<pP0QN-5Wa-9@gated-at.bofh.it> (permalink)
References	<pP0nM-5o8-13@gated-at.bofh.it> <pP0H7-5KL-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 22, 2015 at 12:39:37PM +0100, Chris Wilson wrote:
> On Wed, Jul 22, 2015 at 04:58:47PM +0530, Sudip Mukherjee wrote:
> > If any of the debug file creation fails we were just returning the
> > error code to the drm layer. But the debug files that we created in the
> > process were not removed. And debugfs files are not automatically
> > cleaned up.
> 
> Just handle the failure to add gracefully by only removing the ones we
> add during debugfs cleanup. One thing we do not actually want to do here
> is return an error - not setting up every file in debugfs shouldn't stop
> the driver from loading.
Ok, I will send the v2 day after tomorrow. Today and tomorrow I will
horribly busy in my dayjob.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915: add error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-22 13:30 +0200
  Re: [Intel-gfx] [PATCH] drm/i915: add error path Chris Wilson <chris@chris-wilson.co.uk> - 2015-07-22 13:50 +0200
    Re: [Intel-gfx] [PATCH] drm/i915: add error path Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-22 14:00 +0200

csiph-web