Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1188188
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/i915: fix possible null pointer dereference |
| Date | 2015-07-20 15:30 +0200 |
| Message-ID | <pOjiP-2s6-17@gated-at.bofh.it> (permalink) |
| References | <pOimK-16Y-9@gated-at.bofh.it> <pOiwq-1i3-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > We were dereferencing dev first and then checking if it is NULL. Lets > > check for NULL first and then dereference. > > The code is bonkers. Testing for a lack of a correctly constructed > debugfs seq_file inside the debugfs seq_file callback is inane. I missed seeing before sending this patch that there are some more places where this has been done. Then are you suggesting to remove the test? regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH] drm/i915: fix possible null pointer dereference Chris Wilson <chris@chris-wilson.co.uk> - 2015-07-20 14:40 +0200 Re: [PATCH] drm/i915: fix possible null pointer dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-20 15:30 +0200
csiph-web