Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1188168

Re: [PATCH] drm/i915: fix possible null pointer dereference

Show all headers | View raw

On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote:
> We were dereferencing dev first and then checking if it is NULL. Lets
> check for NULL first and then dereference.

The code is bonkers. Testing for a lack of a correctly constructed
debugfs seq_file inside the debugfs seq_file callback is inane.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drm/i915: fix possible null pointer dereference Chris Wilson <chris@chris-wilson.co.uk> - 2015-07-20 14:40 +0200
  Re: [PATCH] drm/i915: fix possible null pointer dereference Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-20 15:30 +0200

csiph-web