Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1184681
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM |
| Date | Wed, 15 Jul 2015 12:40:01 +0200 |
| Message-ID | <pMsgx-4Rv-9@gated-at.bofh.it> (permalink) |
| References | <pLZxT-5AN-1@gated-at.bofh.it> |
| X-Original-To | Michael Ellerman <mpe@ellerman.id.au>, "Avargil, Raanan" <raanan.avargil@intel.com> |
| X-Extloop1 | 1 |
| X-Ironport-Av | E=Sophos;i="5.15,479,1432623600"; d="asc'?scan'208";a="524644015" |
| Content-Type | multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-VTmvpgczFj7nlI2vzPPt" |
| X-Mailer | Evolution 3.12.11 (3.12.11-1.fc21) |
| MIME-Version | 1.0 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 52 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, aaron.f.brown@intel.com, yanirx.lubetkin@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com |
| X-Original-Date | Wed, 15 Jul 2015 03:30:16 -0700 |
| X-Original-Message-ID | <1436956216.13597.8.camel@intel.com> |
| X-Original-References | <1436846075-29366-1-git-send-email-mpe@ellerman.id.au> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1184681 |
Show key headers only | View raw
[Multipart message — attachments visible in raw view] - view raw
On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used" > warning for e1000e_disable_aspm_locked(). > > Move it inside the existing CONFIG_PM block to avoid the warning. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) NACK, this is already fixed in my next-queue tree. Raanan submitted a patch back on July 6th to resolve this issue, see commit id a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my next-queue tree.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM Michael Ellerman <mpe@ellerman.id.au> - 2015-07-14 06:00 +0200 Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-07-15 12:40 +0200
csiph-web