Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

From	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM
Date	2015-07-15 12:40 +0200
Message-ID	<pMsgx-4Rv-9@gated-at.bofh.it> (permalink)
References	<pLZxT-5AN-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote:
> e1000e_disable_aspm_locked() is only used in __e1000_resume() which is
> inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used"
> warning for e1000e_disable_aspm_locked().
> 
> Move it inside the existing CONFIG_PM block to avoid the warning.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

NACK, this is already fixed in my next-queue tree.  Raanan submitted a
patch back on July 6th to resolve this issue, see commit id
a75787d2246a93d256061db602f252703559af65 in my dev-queue branch of my
next-queue tree.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM Michael Ellerman <mpe@ellerman.id.au> - 2015-07-14 06:00 +0200
  Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside  CONFIG_PM Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2015-07-15 12:40 +0200

csiph-web