Re: [PATCH 3/6] security: Introduce security_settime64()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/6] security: Introduce security_settime64()
Date	Wed, 15 Jul 2015 12:30:01 +0200
Message-ID	<pMs6R-4Gg-7@gated-at.bofh.it> (permalink)
References	<pMnJV-6IC-5@gated-at.bofh.it> <pMnTz-6TS-3@gated-at.bofh.it>
X-Original-To	Baolin Wang <baolin.wang@linaro.org>
User-Agent	Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score	-1.0
X-Linutronix-Spam-Level	-
X-Linutronix-Spam-Status	No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	serge.hallyn@canonical.com, arnd@arndb.de, john.stultz@linaro.org, linux-kernel@vger.kernel.org, james.l.morris@oracle.com, serge@hallyn.com, paul@paul-moore.com, john.johansen@canonical.com, sds@tycho.nsa.gov, casey@schaufler-ca.com, penguin-kernel@I-love.SAKURA.ne.jp, neilb@suse.de, edumazet@google.com, jlayton@primarydata.com, linux-security-module@vger.kernel.org, y2038@lists.linaro.org
X-Original-Date	Wed, 15 Jul 2015 12:24:09 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.11.1507151218060.18576@nanos>
X-Original-References	<cover.1436511577.git.baolin.wang@linaro.org> <ebd8579536b37bbaf60bbb87420f39f72334a777.1436511577.git.baolin.wang@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1184676

Show key headers only | View raw

On Wed, 15 Jul 2015, Baolin Wang wrote:

> security_settime() returns a timespec, which is not year 2038 safe

It returns int, which is year 2038 safe on all systems. Copy and paste
is great, right?

> -int security_settime(const struct timespec *ts, const struct timezone *tz);
> +int security_settime64(const struct timespec64 *ts, const struct timezone *tz);
> +static inline int security_settime(const struct timespec *ts, const struct timezone *tz)
> +{
> +	struct timespec64 ts64 = timespec_to_timespec64(*ts);
> +
> +	return security_settime64(&ts64, tz);
> +}

What's the point of this inline? Explanation is missing in
changelog.

Also this wants follow up patches which fix the call sites and remove
that inline helper again.

> -int cap_settime(const struct timespec *ts, const struct timezone *tz)
> +int cap_settime(const struct timespec64 *ts, const struct timezone *tz)

Changelog is missing that none of the existing hooks is using the ts
argument and therefor the patch is not doing any functional changes.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 0/6] Introduce 64bit accessors and structures required to address y2038 issues in the posix_clock subsystem Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 07:50 +0200
  [PATCH 2/6] timekeeping: Introduce current_kernel_time64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
  [PATCH 3/6] security: Introduce security_settime64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
    Re: [PATCH 3/6] security: Introduce security_settime64() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 12:30 +0200
      Re: [PATCH 3/6] security: Introduce security_settime64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 13:40 +0200
  [PATCH 1/6] time: Introduce struct itimerspec64 Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
  [PATCH 4/6] time: Introduce do_sys_settimeofday64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200
  [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200
    Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 12:40 +0200
      Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 13:50 +0200
        Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 14:00 +0200
          Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-16 04:30 +0200
            Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-16 12:50 +0200
              Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-17 10:40 +0200
  [PATCH 5/6] time: Introduce timespec64_to_jiffies()/jiffies_to_timespec64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200

csiph-web