Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1184707

Re: [PATCH 3/6] security: Introduce security_settime64()

Show all headers | View raw

On 15 July 2015 at 18:24, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 15 Jul 2015, Baolin Wang wrote:
>
>> security_settime() returns a timespec, which is not year 2038 safe
>
> It returns int, which is year 2038 safe on all systems. Copy and paste
> is great, right?
>

Sorry, will fix that.

>> -int security_settime(const struct timespec *ts, const struct timezone *tz);
>> +int security_settime64(const struct timespec64 *ts, const struct timezone *tz);
>> +static inline int security_settime(const struct timespec *ts, const struct timezone *tz)
>> +{
>> +     struct timespec64 ts64 = timespec_to_timespec64(*ts);
>> +
>> +     return security_settime64(&ts64, tz);
>> +}
>
> What's the point of this inline? Explanation is missing in
> changelog.
>
> Also this wants follow up patches which fix the call sites and remove
> that inline helper again.
>

Yes, I'll add this explanation in changelog.

>> -int cap_settime(const struct timespec *ts, const struct timezone *tz)
>> +int cap_settime(const struct timespec64 *ts, const struct timezone *tz)
>
> Changelog is missing that none of the existing hooks is using the ts
> argument and therefor the patch is not doing any functional changes.
>

OK, will add these explanation. Thanks for your comments.

> Thanks,
>
>         tglx



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] Introduce 64bit accessors and structures required to address y2038 issues in the posix_clock subsystem Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 07:50 +0200
  [PATCH 2/6] timekeeping: Introduce current_kernel_time64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
  [PATCH 3/6] security: Introduce security_settime64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
    Re: [PATCH 3/6] security: Introduce security_settime64() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 12:30 +0200
      Re: [PATCH 3/6] security: Introduce security_settime64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 13:40 +0200
  [PATCH 1/6] time: Introduce struct itimerspec64 Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:00 +0200
  [PATCH 4/6] time: Introduce do_sys_settimeofday64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200
  [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200
    Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 12:40 +0200
      Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 13:50 +0200
        Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-15 14:00 +0200
          Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-16 04:30 +0200
            Re: [PATCH 6/6] cputime: Introduce  cputime_to_timespec64()/timespec64_to_cputime() Thomas Gleixner <tglx@linutronix.de> - 2015-07-16 12:50 +0200
              Re: [PATCH 6/6] cputime: Introduce cputime_to_timespec64()/timespec64_to_cputime() Baolin Wang <baolin.wang@linaro.org> - 2015-07-17 10:40 +0200
  [PATCH 5/6] time: Introduce timespec64_to_jiffies()/jiffies_to_timespec64() Baolin Wang <baolin.wang@linaro.org> - 2015-07-15 08:10 +0200

csiph-web